Attachment 18623 Details for Bug 17360 – Add quirk system for AGPMode

[patch] Add quirk system for AGPMode

agpmode_quirks.patch (text/plain), 2.32 KB, created by Bryce Harrington on 2008-09-01 20:46:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bryce Harrington

Created: 2008-09-01 20:46:47 UTC

Size: 2.32 KB

patch

obsolete

>diff --git a/src/atipciids.h b/src/atipciids.h
>index f24f8fb..c30e680 100644
>--- a/src/atipciids.h
>+++ b/src/atipciids.h
>@@ -37,6 +37,7 @@
> #define PCI_VENDOR_ATI			0x1002
> #define PCI_VENDOR_AMD			0x1022
> #define PCI_VENDOR_DELL			0x1028
>+#define PCI_VENDOR_INTEL                0x8086
> 
> #include "ati_pciids_gen.h"
> 
>diff --git a/src/radeon_dri.c b/src/radeon_dri.c
>index 5542d2b..0081826 100644
>--- a/src/radeon_dri.c
>+++ b/src/radeon_dri.c
>@@ -719,6 +719,27 @@ static void RADEONDRIInitGARTValues(RADEONInfoPtr info)
>     info->dri->log2GARTTexGran  = l;
> }
> 
>+/* AGP Mode Quirk List - Certain hostbridge/gfx-card combos don't work with
>+ * the standard AGPMode settings, so we detect and handle these
>+ * on a case-by-base basis with quirks.  To see if an AGPMode is valid, test
>+ * it by setting Option "AGPMode" "1" (or "2", or "4" or "8"). */
>+typedef struct {
>+    unsigned int hostbridgeVendor;
>+    unsigned int hostbridgeDevice;
>+    unsigned int chipVendor;
>+    unsigned int chipDevice;
>+    unsigned int subsysVendor;
>+    unsigned int subsysDevice;
>+    unsigned int defaultMode;
>+} radeon_agpmode_quirk, *radeon_agpmode_quirk_ptr;
>+
>+static radeon_agpmode_quirk radeon_agpmode_quirk_list[] = {
>+    /* Intel 82830 830 Chipset Host Bridge / Mobility M6 LY needs AGPMode 2 (fdo #17360)*/
>+    { PCI_VENDOR_INTEL,0x3575,  PCI_VENDOR_ATI,0x4c59,  PCI_VENDOR_DELL,0x00e3,  2 },
>+
>+    { 0, 0, 0, 0, 0, 0, 0 },
>+};
>+
> /* Set AGP transfer mode according to requests and constraints */
> static Bool RADEONSetAgpMode(RADEONInfoPtr info, ScreenPtr pScreen)
> {
>@@ -741,6 +762,21 @@ static Bool RADEONSetAgpMode(RADEONInfoPtr info, ScreenPtr pScreen)
> 	else defaultMode = 1;
>     }
> 
>+    /* Apply AGPMode Quirks */
>+    radeon_agpmode_quirk_ptr p = radeon_agpmode_quirk_list;
>+    while (p && p->chipDevice != 0) {
>+        if (vendor == p->hostbridgeVendor &&
>+            device == p->hostbridgeDevice &&
>+            PCI_DEV_VENDOR_ID(info->PciInfo) == p->chipVendor &&
>+            PCI_DEV_DEVICE_ID(info->PciInfo) == p->chipDevice &&
>+            PCI_SUB_VENDOR_ID(info->PciInfo) == p->subsysVendor &&
>+            PCI_SUB_DEVICE_ID(info->PciInfo) == p->subsysDevice)
>+        {
>+            defaultMode = p->defaultMode;
>+        }
>+        ++p;
>+    }
>+
>     from = X_DEFAULT;
> 
>     if (xf86GetOptValInteger(info->Options, OPTION_AGP_MODE, &info->dri->agpMode)) {

Actions: View | Splinter Review

Attachments on bug 17360: 18585 | 18620 | 18623 | 18681

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.