Attachment 18874 Details for Bug 17580 – fixes this problem.

[patch] fixes this problem.

poppler-glib-demo-empty-choice.diff (text/plain), 991 bytes, created by Kouhei Sutou on 2008-09-14 22:59:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kouhei Sutou

Created: 2008-09-14 22:59:29 UTC

Size: 991 bytes

patch

obsolete

>diff --git a/glib/demo/forms.c b/glib/demo/forms.c
>index e5eed27..e4b1fd8 100644
>--- a/glib/demo/forms.c
>+++ b/glib/demo/forms.c
>@@ -208,11 +208,13 @@ pgd_form_field_view_set_field (GtkWidget *field_view,
> 
> 		pgd_form_field_view_add_choice_items (GTK_TABLE (table), field, &selected, &row);
> 
>-		item = poppler_form_field_choice_get_item (field, selected);
>-		text = g_strdup_printf ("%d (%s)", selected, item);
>-		g_free (item);
>-		pgd_table_add_property (GTK_TABLE (table), "Selected item:", text, &row);
>-		g_free (text);
>+		if (poppler_form_field_choice_get_n_items (field) > selected) {
>+			item = poppler_form_field_choice_get_item (field, selected);
>+			text = g_strdup_printf ("%d (%s)", selected, item);
>+			g_free (item);
>+			pgd_table_add_property (GTK_TABLE (table), "Selected item:", text, &row);
>+			g_free (text);
>+		}
> 
> 		text = poppler_form_field_choice_get_text (field);
> 		pgd_table_add_property (GTK_TABLE (table), "Contents:", text, &row);

Actions: View | Splinter Review

Attachments on bug 17580: 18873 | 18874

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.