Attachment 19512 Details for Bug 16167 – 0001-Xi-don-t-memcpy-the-KeyClassRec-from-SD-to-MD.patch

[patch] 0001-Xi-don-t-memcpy-the-KeyClassRec-from-SD-to-MD.patch

0001-Xi-don-t-memcpy-the-KeyClassRec-from-SD-to-MD.patch (text/plain), 1.06 KB, created by Peter Hutterer on 2008-10-08 23:10:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Hutterer

Created: 2008-10-08 23:10:19 UTC

Size: 1.06 KB

patch

obsolete

>From 82bfe334f61253461d24981c728b2c63b5d9e70a Mon Sep 17 00:00:00 2001
>From: Peter Hutterer <peter.hutterer@redhat.com>
>Date: Thu, 9 Oct 2008 16:23:24 +1030
>Subject: [PATCH] Xi: don't memcpy the KeyClassRec from SD to MD.
>
>Most of its component get copied during CopyKeyClass anyway.
>The ones that aren't:
>  postdown - never changed for virtual devices anyway.
>  down - shouldn't change that without sending events.
>
>memcpy'ing the struct also copied mapWidth, which means we didn't realloc
>during SetKeySymsMap lateron, overwriting the memory assigned to us.
>---
> Xi/exevents.c |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>diff --git a/Xi/exevents.c b/Xi/exevents.c
>index 6f65279..155cb9b 100644
>--- a/Xi/exevents.c
>+++ b/Xi/exevents.c
>@@ -527,8 +527,6 @@ DeepCopyDeviceClasses(DeviceIntPtr from, DeviceIntPtr to)
>         oldXkbInfo      = to->key->xkbInfo;
> #endif
> 
>-        memcpy(to->key, from->key, sizeof(KeyClassRec));
>-
>         if (!oldMap) /* newly created key struct */
>         {
>             int bytes = (to->key->curKeySyms.maxKeyCode -
>-- 
>1.5.4.3
>

Actions: View | Splinter Review

Attachments on bug 16167: 16831 | 16832 | 16849 | 16903 | 16909 | 17740 | 17741 | 17743 | 17744 | 18042 | 18044 | 19512

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.