Attachment 3066 Details for Bug 4263 – Use 8-pixel strips for vertical gradients

[patch] Use 8-pixel strips for vertical gradients

cairo-vertical-pattern-strip.patch (text/plain), 1.21 KB, created by Owen Taylor on 2005-08-27 16:09:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Taylor

Created: 2005-08-27 16:09:44 UTC

Size: 1.21 KB

patch

obsolete

>Index: ChangeLog
>===================================================================
>RCS file: /cvs/cairo/cairo/ChangeLog,v
>retrieving revision 1.1017
>diff -u -p -r1.1017 ChangeLog
>--- ChangeLog	25 Aug 2005 09:59:40 -0000	1.1017
>+++ ChangeLog	27 Aug 2005 23:07:36 -0000
>@@ -1,3 +1,10 @@
>+2005-08-27  Owen Taylor  <otaylor@redhat.com>
>+
>+	* src/cairo-pattern.c (_cairo_pattern_acquire_surface_for_gradient): 
>+	Use a 8xN rather than a 1xN strip for a vertical gradient. This
>+	is much more tolerant of slow compositing code, and is worth some
>+	extra expense computing the gradient.
>+
> 2005-08-25  Tor Lillqvist  <tml@novell.com>
> 
> 	* Makefile.am (developer_zip_file): Include the documentation, too.
>Index: src/cairo-pattern.c
>===================================================================
>RCS file: /cvs/cairo/cairo/src/cairo-pattern.c,v
>retrieving revision 1.64
>diff -u -p -r1.64 cairo-pattern.c
>--- src/cairo-pattern.c	24 Aug 2005 02:52:09 -0000	1.64
>+++ src/cairo-pattern.c	27 Aug 2005 23:07:36 -0000
>@@ -1230,8 +1230,8 @@ _cairo_pattern_acquire_surface_for_gradi
> 	    height = 1;
> 	    repeat = TRUE;
> 	}
>-	if (is_vertical) {
>-	    width = 1;
>+	if (is_vertical && width > 8) {
>+	    width = 8;
> 	    repeat = TRUE;
> 	}
>     }

Actions: View | Splinter Review

Attachments on bug 4263: 3059 | 3063 | 3064 | 3065 | 3066 | 3067 | 3068

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.