Attachment 31318 Details for Bug 25189 – patch to avoid division-by-zero

[patch] patch to avoid division-by-zero

patch-ap (text/plain), 1.07 KB, created by M.Drochner on 2009-11-19 10:15:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: M.Drochner

Created: 2009-11-19 10:15:09 UTC

Size: 1.07 KB

patch

obsolete

>$NetBSD: patch-ap,v 1.1 2009/11/19 17:58:41 drochner Exp $
>
>--- poppler/Gfx.cc.orig	2009-09-09 23:25:11.000000000 +0200
>+++ poppler/Gfx.cc
>@@ -2462,7 +2462,10 @@ void Gfx::doAxialShFill(GfxAxialShading 
>   if (out->useFillColorStop()) {
>     // make sure we add stop color when t = tMin
>     state->setFillColor(&color0);
>-    out->updateFillColorStop(state, (tt - tMin)/(tMax - tMin));
>+    if (tMax == tMin)
>+	out->updateFillColorStop(state, tMin);
>+    else
>+    	out->updateFillColorStop(state, (tt - tMin)/(tMax - tMin));
>   }
> 
>   // compute the coordinates of the point on the t axis at t = tMin;
>@@ -2602,9 +2605,12 @@ void Gfx::doAxialShFill(GfxAxialShading 
> 
>     // set the color
>     state->setFillColor(&color0);
>-    if (out->useFillColorStop())
>-      out->updateFillColorStop(state, (ta[j] - tMin)/(tMax - tMin));
>-    else
>+    if (out->useFillColorStop()) {
>+      if (tMax == tMin)
>+	out->updateFillColorStop(state, tMin);
>+      else
>+        out->updateFillColorStop(state, (ta[j] - tMin)/(tMax - tMin));
>+    } else
>       out->updateFillColor(state);
> 
>     if (needExtend) {

Actions: View | Splinter Review

Attachments on bug 25189: 31318 | 31342 | 31344

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.