Attachment 33517 Details for Bug 26668 – fix

[patch] fix

0001-drm-radeon-kms-atom-fix-shr-shl-ops.patch (text/plain), 1.27 KB, created by Alex Deucher on 2010-02-23 19:11:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2010-02-23 19:11:51 UTC

Size: 1.27 KB

patch

obsolete

>From 049090b0d3417e47f6c9835d6e9d0624b3153eb1 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexdeucher@gmail.com>
>Date: Tue, 23 Feb 2010 21:56:12 -0500
>Subject: [PATCH] drm/radeon/kms/atom: fix shr/shl ops
>
>The whole attribute table is valid for
>shr/shl ops.
>
>Fixes fdo bug 26668
>
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>---
> drivers/gpu/drm/radeon/atom.c |    4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c
>index bd0c843..654dbcb 100644
>--- a/drivers/gpu/drm/radeon/atom.c
>+++ b/drivers/gpu/drm/radeon/atom.c
>@@ -879,8 +879,6 @@ static void atom_op_shl(atom_exec_context *ctx, int *ptr, int arg)
> 	uint8_t attr = U8((*ptr)++), shift;
> 	uint32_t saved, dst;
> 	int dptr = *ptr;
>-	attr &= 0x38;
>-	attr |= atom_def_dst[attr >> 3] << 6;
> 	SDEBUG("   dst: ");
> 	dst = atom_get_dst(ctx, arg, attr, ptr, &saved, 1);
> 	shift = atom_get_src(ctx, attr, ptr);
>@@ -895,8 +893,6 @@ static void atom_op_shr(atom_exec_context *ctx, int *ptr, int arg)
> 	uint8_t attr = U8((*ptr)++), shift;
> 	uint32_t saved, dst;
> 	int dptr = *ptr;
>-	attr &= 0x38;
>-	attr |= atom_def_dst[attr >> 3] << 6;
> 	SDEBUG("   dst: ");
> 	dst = atom_get_dst(ctx, arg, attr, ptr, &saved, 1);
> 	shift = atom_get_src(ctx, attr, ptr);
>-- 
>1.5.6.3
>

Actions: View | Splinter Review

Attachments on bug 26668: 33452 | 33453 | 33454 | 33456 | 33457 | 33458 | 33460 | 33517

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.