Attachment 33648 Details for Bug 26802 – Patch to reduce msvc warnings

[patch] Patch to reduce msvc warnings

poppler-0.12.4.diff (text/plain), 2.04 KB, created by Christian Ehrlicher on 2010-02-28 11:39:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian Ehrlicher

Created: 2010-02-28 11:39:28 UTC

Size: 2.04 KB

patch

obsolete

>--- poppler\Annot.cc.orig	2010-01-17 01:06:58.000000000 +0100
>+++ poppler\Annot.cc	2010-02-28 20:12:53.703125000 +0100
>@@ -750,7 +750,7 @@
>   obj1.free();
> 
>   if (dict->lookup("FB", &obj1)->isBool()) {
>-    fullyBounds = obj1.getBool();
>+    fullyBounds = obj1.getBool() == gTrue;
>   } else {
>     fullyBounds = gFalse;
>   }
>@@ -1953,7 +1953,7 @@
>   obj1.free();
> 
>   if (dict->lookup("Cap", &obj1)->isBool()) {
>-    caption = obj1.getBool();
>+    caption = obj1.getBool() == gTrue;
>   } else {
>     caption = gFalse;
>   }
>--- poppler\Catalog.h.orig	2010-01-17 01:06:57.000000000 +0100
>+++ poppler\Catalog.h	2010-02-28 20:09:54.156250000 +0100
>@@ -117,7 +117,7 @@
>   GooString *checksum() { return m_checksum; }
>   GooString *mimeType() { return m_mimetype; }
>   Object &streamObject() { return m_objStr; }
>-  bool isOk() { return m_objStr.isStream(); }
>+  bool isOk() { return m_objStr.isStream() == gTrue; }
> 
> private:
>   GooString *m_name;
>--- poppler\Gfx.cc.orig	2010-01-23 00:54:42.000000000 +0100
>+++ poppler\Gfx.cc	2010-02-28 20:22:53.046875000 +0100
>@@ -4474,7 +4474,7 @@
>   bool hidden = mc && mc->ocSuppressed;
>   while (!hidden && mc && mc->next) {
>     mc = mc->next;
>-    hidden = mc->ocSuppressed;
>+    hidden = mc->ocSuppressed == gTrue;
>   }
>   return hidden;
> }
>--- poppler\GfxState.h.orig	2010-01-17 01:06:58.000000000 +0100
>+++ poppler\GfxState.h	2010-02-28 20:11:10.468750000 +0100
>@@ -185,8 +185,8 @@
>   virtual void getGray(GfxColor *color, GfxGray *gray) = 0;
>   virtual void getRGB(GfxColor *color, GfxRGB *rgb) = 0;
>   virtual void getCMYK(GfxColor *color, GfxCMYK *cmyk) = 0;
>-  virtual void getGrayLine(Guchar */*in*/, Guchar */*out*/, int /*length*/) {}
>-  virtual void getRGBLine(Guchar */*in*/, unsigned int */*out*/, int /*length*/) {}
>+  virtual void getGrayLine(Guchar * /*in*/, Guchar * /*out*/, int /*length*/) {}
>+  virtual void getRGBLine(Guchar * /*in*/, unsigned int * /*out*/, int /*length*/) {}
> 
>   // Does this ColorSpace use getRGBLine?
>   virtual GBool useGetRGBLine() { return gFalse; }

Actions: View | Splinter Review

Attachments on bug 26802: 33648

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.