Attachment 34329 Details for Bug 19195 – 0001-Add-DBUS_GNUC_PRINTF-checks-to-new-formatting-functi.patch

[patch] 0001-Add-DBUS_GNUC_PRINTF-checks-to-new-formatting-functi.patch

0001-Add-DBUS_GNUC_PRINTF-checks-to-new-formatting-functi.patch (text/plain), 1.36 KB, created by Colin Walters on 2010-03-22 10:38:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Walters

Created: 2010-03-22 10:38:24 UTC

Size: 1.36 KB

patch

obsolete

>From c555a7980e06079353ae897abd91d2f5d43f1535 Mon Sep 17 00:00:00 2001
>From: Colin Walters <walters@verbum.org>
>Date: Mon, 22 Mar 2010 10:38:12 -0400
>Subject: [PATCH 1/2] Add DBUS_GNUC_PRINTF checks to new formatting functions
>
>Otherwise we don't get GCC warnings.
>---
> bus/bus.c           |    3 +++
> dbus/dbus-sysdeps.h |    2 +-
> 2 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/bus/bus.c b/bus/bus.c
>index 60de72a..fd8a872 100644
>--- a/bus/bus.c
>+++ b/bus/bus.c
>@@ -1176,6 +1176,9 @@ bus_context_get_reply_timeout (BusContext *context)
> }
> 
> void
>+bus_context_log (BusContext *context, DBusSystemLogSeverity severity, const char *msg, ...) _DBUS_GNUC_PRINTF (3, 4);
>+
>+void
> bus_context_log (BusContext *context, DBusSystemLogSeverity severity, const char *msg, ...)
> {
>   va_list args;
>diff --git a/dbus/dbus-sysdeps.h b/dbus/dbus-sysdeps.h
>index 12e9124..7817e04 100644
>--- a/dbus/dbus-sysdeps.h
>+++ b/dbus/dbus-sysdeps.h
>@@ -446,7 +446,7 @@ typedef enum {
>   DBUS_SYSTEM_LOG_FATAL
> } DBusSystemLogSeverity;
> 
>-void _dbus_system_log (DBusSystemLogSeverity severity, const char *msg, ...);
>+void _dbus_system_log (DBusSystemLogSeverity severity, const char *msg, ...) _DBUS_GNUC_PRINTF (2, 3);
> void _dbus_system_logv (DBusSystemLogSeverity severity, const char *msg, va_list args);
> 
> /* Define DBUS_VA_COPY() to do the right thing for copying va_list variables.
>-- 
>1.6.6.1
>

Actions: View | Splinter Review

Attachments on bug 19195: 34329 | 34330

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.