Attachment 44215 Details for Bug 31159 – clamp in sample_compare

[patch] clamp in sample_compare

sp_tex_sample.c.patch (text/plain), 2.89 KB, created by Philip Taylor on 2011-03-07 16:00:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philip Taylor

Created: 2011-03-07 16:00:16 UTC

Size: 2.89 KB

patch

obsolete

>--- sp_tex_sample.c.orig	2011-01-02 22:58:35.000000000 +0000
>+++ sp_tex_sample.c	2011-03-07 23:52:50.341369498 +0000
>@@ -1568,62 +1568,68 @@ sample_compare(struct tgsi_sampler *tgsi
>                const float c0[QUAD_SIZE],
>                enum tgsi_sampler_control control,
>                float rgba[NUM_CHANNELS][QUAD_SIZE])
> {
>    struct sp_sampler_varient *samp = sp_sampler_varient(tgsi_sampler);
>    const struct pipe_sampler_state *sampler = samp->sampler;
>    int j, k0, k1, k2, k3;
>    float val;
>+   float pc0, pc1, pc2, pc3;
> 
>    samp->mip_filter(tgsi_sampler, s, t, p, c0, control, rgba);
> 
>+   pc0 = CLAMP(p[0], 0.0F, 1.0F);
>+   pc1 = CLAMP(p[1], 0.0F, 1.0F);
>+   pc2 = CLAMP(p[2], 0.0F, 1.0F);
>+   pc3 = CLAMP(p[3], 0.0F, 1.0F);
>+
>    /**
>     * Compare texcoord 'p' (aka R) against texture value 'rgba[0]'
>     * When we sampled the depth texture, the depth value was put into all
>     * RGBA channels.  We look at the red channel here.
>     */
> 
>    /* compare four texcoords vs. four texture samples */
>    switch (sampler->compare_func) {
>    case PIPE_FUNC_LESS:
>-      k0 = p[0] < rgba[0][0];
>-      k1 = p[1] < rgba[0][1];
>-      k2 = p[2] < rgba[0][2];
>-      k3 = p[3] < rgba[0][3];
>+      k0 = pc0 < rgba[0][0];
>+      k1 = pc1 < rgba[0][1];
>+      k2 = pc2 < rgba[0][2];
>+      k3 = pc3 < rgba[0][3];
>       break;
>    case PIPE_FUNC_LEQUAL:
>-      k0 = p[0] <= rgba[0][0];
>-      k1 = p[1] <= rgba[0][1];
>-      k2 = p[2] <= rgba[0][2];
>-      k3 = p[3] <= rgba[0][3];
>+      k0 = pc0 <= rgba[0][0];
>+      k1 = pc1 <= rgba[0][1];
>+      k2 = pc2 <= rgba[0][2];
>+      k3 = pc3 <= rgba[0][3];
>       break;
>    case PIPE_FUNC_GREATER:
>-      k0 = p[0] > rgba[0][0];
>-      k1 = p[1] > rgba[0][1];
>-      k2 = p[2] > rgba[0][2];
>-      k3 = p[3] > rgba[0][3];
>+      k0 = pc0 > rgba[0][0];
>+      k1 = pc1 > rgba[0][1];
>+      k2 = pc2 > rgba[0][2];
>+      k3 = pc3 > rgba[0][3];
>       break;
>    case PIPE_FUNC_GEQUAL:
>-      k0 = p[0] >= rgba[0][0];
>-      k1 = p[1] >= rgba[0][1];
>-      k2 = p[2] >= rgba[0][2];
>-      k3 = p[3] >= rgba[0][3];
>+      k0 = pc0 >= rgba[0][0];
>+      k1 = pc1 >= rgba[0][1];
>+      k2 = pc2 >= rgba[0][2];
>+      k3 = pc3 >= rgba[0][3];
>       break;
>    case PIPE_FUNC_EQUAL:
>-      k0 = p[0] == rgba[0][0];
>-      k1 = p[1] == rgba[0][1];
>-      k2 = p[2] == rgba[0][2];
>-      k3 = p[3] == rgba[0][3];
>+      k0 = pc0 == rgba[0][0];
>+      k1 = pc1 == rgba[0][1];
>+      k2 = pc2 == rgba[0][2];
>+      k3 = pc3 == rgba[0][3];
>       break;
>    case PIPE_FUNC_NOTEQUAL:
>-      k0 = p[0] != rgba[0][0];
>-      k1 = p[1] != rgba[0][1];
>-      k2 = p[2] != rgba[0][2];
>-      k3 = p[3] != rgba[0][3];
>+      k0 = pc0 != rgba[0][0];
>+      k1 = pc1 != rgba[0][1];
>+      k2 = pc2 != rgba[0][2];
>+      k3 = pc3 != rgba[0][3];
>       break;
>    case PIPE_FUNC_ALWAYS:
>       k0 = k1 = k2 = k3 = 1;
>       break;
>    case PIPE_FUNC_NEVER:
>       k0 = k1 = k2 = k3 = 0;
>       break;
>    default:

Actions: View | Splinter Review

Attachments on bug 31159: 39808 | 44215 | 44230

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.