Attachment 68309 Details for Bug 55785 – fix (submitted to mailing list)

[patch] fix (submitted to mailing list)

0001-dix-fix-Ungrab-action-55785.patch (text/plain), 1.17 KB, created by Lionel Elie Mamane on 2012-10-09 01:25:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lionel Elie Mamane

Created: 2012-10-09 01:25:03 UTC

Size: 1.17 KB

patch

obsolete

>From 4e4d2522b3125b8fa43405f63171e75c30f6a4a7 Mon Sep 17 00:00:00 2001
>From: Lionel Elie Mamane <lionel@mamane.lu>
>Date: Tue, 9 Oct 2012 02:37:32 +0200
>Subject: [PATCH] dix: fix Ungrab action #55785
>
>UngrabAllDevices(Bool kill_client):
>If we are not going to kill the client (kill_clients false),
>we need to deactivate grabs of active clients, too.
>(If we are going to kill the client,
> no need to deactivate the grab,
> as this will be done as part of the client kill.)
>
>Fixes: X.Org Bug 55785 <http://bugs.freedesktop.org/show_bug.cgi?id=55785>
>
>Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
>---
> dix/grabs.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/dix/grabs.c b/dix/grabs.c
>index 55bf64f..fe79674 100644
>--- a/dix/grabs.c
>+++ b/dix/grabs.c
>@@ -179,7 +179,7 @@ UngrabAllDevices(Bool kill_client)
>             continue;
>         PrintDeviceGrabInfo(dev);
>         client = clients[CLIENT_ID(dev->deviceGrab.grab->resource)];
>-        if (!client || client->clientGone)
>+        if (!kill_client || !client || client->clientGone)
>             dev->deviceGrab.DeactivateGrab(dev);
>         if (kill_client)
>             CloseDownClient(client);
>-- 
>1.7.9
>

Actions: View | Splinter Review

Attachments on bug 55785: 68309

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.