Attachment 25580 Details for Bug 21609 – Patch as described

[patch] Patch as described

0001-Don-t-use-an-alpha-texture-format-for-GLX_TEXTURE_FO.patch (text/plain), 1.28 KB, created by Owen Taylor on 2009-05-06 20:33:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Taylor

Created: 2009-05-06 20:33:01 UTC

Size: 1.28 KB

patch

obsolete

>From f2f7967eb5736216ffeb58afe84db18634fc8bba Mon Sep 17 00:00:00 2001
>From: Owen W. Taylor <otaylor@fishsoup.net>
>Date: Wed, 6 May 2009 22:42:50 -0400
>Subject: [PATCH] Don't use an alpha texture format for GLX_TEXTURE_FORMAT_RGB_EXT
>
>In r300SetTexBuffer2(), if the passed in text glx_texture_format
>is GLX_TEXTURE_FORMAT_RGB_EXT, then we should use an RGB-only
>texture format, even if the DRI buffer has four channels.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=21609
>---
> src/mesa/drivers/dri/r300/r300_texstate.c |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/r300/r300_texstate.c b/src/mesa/drivers/dri/r300/r300_texstate.c
>index 2d7ad55..8da9439 100644
>--- a/src/mesa/drivers/dri/r300/r300_texstate.c
>+++ b/src/mesa/drivers/dri/r300/r300_texstate.c
>@@ -448,7 +448,10 @@ void r300SetTexBuffer2(__DRIcontext *pDRICtx, GLint target, GLint glx_texture_fo
> 	pitch_val = rb->pitch;
> 	switch (rb->cpp) {
> 	case 4:
>-		t->pp_txformat = R300_EASY_TX_FORMAT(X, Y, Z, W, W8Z8Y8X8);
>+		if (glx_texture_format == GLX_TEXTURE_FORMAT_RGB_EXT)
>+			t->pp_txformat = R300_EASY_TX_FORMAT(X, Y, Z, ONE, W8Z8Y8X8);
>+		else
>+			t->pp_txformat = R300_EASY_TX_FORMAT(X, Y, Z, W, W8Z8Y8X8);
> 		t->pp_txfilter |= tx_table[2].filter;
> 		pitch_val /= 4;
> 		break;
>-- 
>1.6.2.2
>

Actions: View | Splinter Review

Attachments on bug 21609: 25580

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.