Attachment 33576 Details for Bug 26543 – 0001-dix-Clip-only-into-axis-ranges-if-we-re-in-absolute-.patch

[patch] 0001-dix-Clip-only-into-axis-ranges-if-we-re-in-absolute-.patch

0001-dix-Clip-only-into-axis-ranges-if-we-re-in-absolute-.patch (text/plain), 1.37 KB, created by Peter Hutterer on 2010-02-25 20:26:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Hutterer

Created: 2010-02-25 20:26:53 UTC

Size: 1.37 KB

patch

obsolete

>From 7840203027b67ffb3f0edfa58ba28ae232a293dd Mon Sep 17 00:00:00 2001
>From: Peter Hutterer <peter.hutterer@who-t.net>
>Date: Fri, 26 Feb 2010 14:02:09 +1000
>Subject: [PATCH] dix: Clip only into axis ranges if we're in absolute mode.
>
>A device in relative mode can easily provide valuators outside of the axis
>range.
>
>Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
>---
> dix/getevents.c |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/dix/getevents.c b/dix/getevents.c
>index 82bb77b..197deb4 100644
>--- a/dix/getevents.c
>+++ b/dix/getevents.c
>@@ -710,7 +710,7 @@ moveRelative(DeviceIntPtr dev, int *x, int *y,
>     /* if attached, clip both x and y to the defined limits (usually
>      * co-ord space limit). If it is attached, we need x/y to go over the
>      * limits to be able to change screens. */
>-    if(dev->u.master) {
>+    if(dev->u.master && dev->valuator->mode == Absolute) {
>         clipAxis(dev, 0, x);
>         clipAxis(dev, 1, y);
>     }
>@@ -720,7 +720,8 @@ moveRelative(DeviceIntPtr dev, int *x, int *y,
>     for (; i < num; i++)
>     {
>         dev->last.valuators[i + first] += valuators[i];
>-        clipAxis(dev, i, &dev->last.valuators[i + first]);
>+        if (dev->valuator->mode == Absolute)
>+            clipAxis(dev, i, &dev->last.valuators[i + first]);
>         valuators[i] = dev->last.valuators[i + first];
>     }
> }
>-- 
>1.6.6.1
>

Actions: View | Splinter Review

Attachments on bug 26543: 33576

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.