Bug 10189

Summary:	directfb code doesn't build out of the source directory
Product:	cairo	Reporter:	Sebastien Bacher <seb128>
Component:	general	Assignee:	Carl Worth <cworth>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	medium
Version:	1.3.16
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Sebastien Bacher 2007-03-05 14:21:58 UTC

* untar the 1.3.16 tarball to /tmp
* cd /tmp/cairo-1.3.6
* mkdir build
* cd build
* /tmp/cairo-1.3.16/configure --enable-directfb
* make

/tmp/cairo-1.3.16/boilerplate/cairo-test-directfb.c: In function 'create_directfb_window_surface':
/tmp/cairo-1.3.16/boilerplate/cairo-test-directfb.c:86: error: implicit declaration of function 'cairo_directfb_surface_create'
/tmp/cairo-1.3.16/boilerplate/cairo-test-directfb.c:86: warning: nested extern declaration of 'cairo_directfb_surface_create'
/tmp/cairo-1.3.16/boilerplate/cairo-test-directfb.c:86: warning: return makes pointer from integer without a cast
/tmp/cairo-1.3.16/boilerplate/cairo-test-directfb.c: In function 'create_directfb_bitmap_surface':
/tmp/cairo-1.3.16/boilerplate/cairo-test-directfb.c:103: warning: return makes pointer from integer without a cast

Comment 1 Behdad Esfahbod 2007-03-05 15:42:54 UTC

Can't reproduce with master.
Sebastien, care giving it a quick try?  We are getting 1.4.0 out any minute now.

Comment 2 Sebastien Bacher 2007-03-06 04:02:11 UTC

The bug is there with 1.4.0 and breaks the Ubuntu package

Comment 3 Carl Worth 2007-03-15 21:47:50 UTC

Behdad committed two workaround-patches which might be useful for applying to a distribution's release of 1.4.0:

http://gitweb.freedesktop.org/?p=cairo;a=commitdiff;h=2894ed19a3acd955a5d0e2f5a231a6f1eee8ac06
http://gitweb.freedesktop.org/?p=cairo;a=commitdiff;h=994dd1a134484d7a1ee246906f21f02d916014a8

Later, he also found the real bug and made the real fix which is to not ship a cairo-features.h file in the tar file:

http://gitweb.freedesktop.org/?p=cairo;a=commitdiff;h=a7595c1295ba1a58b452b1df31d02776e5c17c0f

So this bug shouldn't appear again.

-Carl

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.