Bug 10406

Summary: quartz backend fails font-matrix-translation test
Product: cairo Reporter: Brian Ewins <Brian.Ewins>
Component: quartz backendAssignee: Vladimir Vukicevic <vladimir>
Status: RESOLVED FIXED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: normal    
Priority: medium    
Version: 1.4.3   
Hardware: Other   
OS: Mac OS X (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: fix the offsets being used in the font matrix

Description Brian Ewins 2007-03-25 15:15:06 UTC
The text in this test is displayed with the wrong offsets. Patch follows.
Comment 1 Brian Ewins 2007-03-25 15:23:22 UTC
Created attachment 9293 [details] [review]
fix the offsets being used in the font matrix

This patch only affects text which have offsets in the font matrix, and is really just an inlining & fix of the code that was there before. Should be safe enough to apply. With this in all of the quartz font stuff looks basically correct.

Only thing I'm uncomfortable with is a lack of a good reason why the offsets needed zero'd. That was necessary elsewhere before I found the bug in c8e37af4b06fffe1aa1a1c3d2cd6481cc2cf8938 - makes me wonder if this is covering up another matrix usage bug.
Comment 2 Chris Wilson 2008-10-10 16:27:23 UTC
Reading (admittedly unfamiliar) code this is precisely what it currently does.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.