Bug 12369

Summary: Update to gb symbols for Apple Pro keyboard
Product: xkeyboard-config Reporter: Andrew Flegg <andrew>
Component: GeneralAssignee: xkb
Status: RESOLVED INVALID QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
URL: http://www.bleb.org/software/xkeyboard-config-apple_pro.patch
Whiteboard:
i915 platform: i915 features:
Attachments: Patch against /usr/share/X11/xkb/symbols/gb for Apple Pro USB keyboard

Description Andrew Flegg 2007-09-09 03:44:16 UTC
The new Apple Pro aluminimum USB keyboard has an incomplete mapping for the UK layout.

Attached is a patch against CVS which fixes the top-left and bottom-left keys, maps the additional number pad keys & function keys, and changes the accents to be more consistent for what a UK user would expect.
Comment 1 Andrew Flegg 2007-09-09 03:45:08 UTC
Created attachment 11475 [details] [review]
Patch against /usr/share/X11/xkb/symbols/gb for Apple Pro USB keyboard
Comment 2 Sergey V. Udaltsov 2007-09-09 03:55:14 UTC
Andrew, I am not excited about your patch. It does not look like UK-specific but rather as model-specific. Would you consider adding new model (and putting new section into symbols/inet)?
Comment 3 Andrew Flegg 2007-09-09 04:03:43 UTC
Perhaps you could point me in the direction of good documentation? The Macintosh keyboard symbols seem spread across, and duplicated in, at least symbols/gb and symbols/macintosh_vndr/gb.

Logically, the second place seems more sensible, but after already selecting a model of "apple", as a user having "gb" as the layout in xorg.conf makes more sense than "macintosh_vndr/gb".
Comment 4 Sergey V. Udaltsov 2007-09-09 04:21:43 UTC
> Perhaps you could point me in the direction of good documentation? The
> Macintosh keyboard symbols seem spread across, and duplicated in, at least
> symbols/gb and symbols/macintosh_vndr/gb.
Unfortunately, there is no "good documentation" here. There is only documentation mentioned at xkeyboard-config home page:
http://www.freedesktop.org/wiki/Software/XKeyboardConfig. See the Links section. But it would not help you much. The macintosh_vndr directory is badly maintained. The "mac" section in symbols/gb only describes the keys which are UK-specific on mac keyboards (well, at least that's what I think it does:)

There is mac-specific model in symbols/inet already, so it would not be difficult to use it as example.
Comment 5 Andrew Flegg 2007-09-09 05:25:00 UTC
Sorry, I see where I've caused confusion.

Only the FK* definitions should go in symbols/inet, I think. Although, I can't get X.org to report the keysyms when I press Right-Alt F3, say - it still comes up as F3 with a modifier. If X.org doesn't support reporting different keysyms for function + modifier, it's not worth keeping the definitions anyway ;-)

The TLDE, AC11 and LSGT keys are all UK-layout on the new Apple keyboard. These should go in symbols/gb, probably?

I04, I77, NFER, NMLK and KPEQ should go in the general Apple one? Which'd be what?

Thanks for your prompt help with this.
Comment 6 Sergey V. Udaltsov 2007-09-09 06:27:20 UTC
> Only the FK* definitions should go in symbols/inet, I think. Although, I can't
> get X.org to report the keysyms when I press Right-Alt F3, say - it still comes
> up as F3 with a modifier. If X.org doesn't support reporting different keysyms
> for function + modifier, it's not worth keeping the definitions anyway ;-)
Consider using different types for FK* keys. For example, FOUR_LEVEL (see types/extra).

> The TLDE, AC11 and LSGT keys are all UK-layout on the new Apple keyboard. These
> should go in symbols/gb, probably?
Yes it sounds logical.

> I04, I77, NFER, NMLK and KPEQ should go in the general Apple one? Which'd be
> what?
I would say so.

> Thanks for your prompt help with this.
Thanks for you contribution:)
Comment 7 Benjamin Close 2008-01-11 02:39:05 UTC
Bugzilla Upgrade Mass Bug Change

NEEDSINFO state was removed in Bugzilla 3.x, reopening any bugs previously listed as NEEDSINFO.

  - benjsc
    fd.o Wrangler
Comment 8 Sergey V. Udaltsov 2008-12-22 14:09:08 UTC
No reply from Andrew for 1+ year.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.