| Summary: | Xephyr emits MotionNotify before all ButtonPress and ButtonRelease events | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Tomas Janousek <tomi> |
| Component: | Server/DDX/Xephyr | Assignee: | Matthew Allum <mallum> |
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | |||
|
Description
Tomas Janousek
2008-05-31 14:58:14 UTC
On Sat, May 31, 2008 at 02:58:42PM -0700, bugzilla-daemon@freedesktop.org wrote: > Xephyr emits MotionNotify before all ButtonPress and ButtonRelease events, when > the mouse hasn't actually moved. This makes some apps (like fluxbox) think that > the user has dragged the thing. I'm attaching a simple patch, no idea if it > doesn't break something though. The patch isn't quite correct since it does not accommodate for absolute devices (in which case 0 may a valid coordinate). Care to fix it up? Created attachment 16857 [details] [review] improved patch Well, I can try. Dunno how to test, but this might be it. Created attachment 16887 [details] [review] 0001-kdrive-don-t-post-motion-event-if-there-was-no-moti.patch cherry-picked from master && backported. Please give this one a try, I don't have a 1.4 setup here. Basically the same as yours, but I cleaned it up a bit. I was on server-1.5-branch, and it works. I did not test the absolute execution path though, since I don't know how, but the changes you did to the patch are definitely correct. 'dixflags = POINTER_RELATIVE & POINTER_ACCELERATE;' erm ... Created attachment 17051 [details] [review] 0001-kdrive-don-t-post-motion-event-if-there-was-no-moti.patch ah yeah. & ain't the same as "and", isn't it... sorry about that. updated. On Wed, Jun 11, 2008 at 01:06:38AM -0700, bugzilla-daemon@freedesktop.org wrote: > Created an attachment (id=17051) > --> (http://bugs.freedesktop.org/attachment.cgi?id=17051) > 0001-kdrive-don-t-post-motion-event-if-there-was-no-moti.patch > > ah yeah. & ain't the same as "and", isn't it... sorry about that. updated. You're hardly the first. :) Pushed to master as 26e7e69ab893d1f2b35213250ada40ec90944f62. Pushed to server-1.5-branch as ac1db454497ff1839aa7f7ee0649ede112824ed9. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.