Bug 18808

Summary: /usr/lib/libxcb-aux.so.0.0.0 calls exit()
Product: XCB Reporter: Michal Nowak <mnowak>
Component: UtilsAssignee: xcb mailing list dummy <xcb>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Proposed patch

Description Michal Nowak 2008-11-28 15:26:46 UTC
Created attachment 20680 [details] [review]
Proposed patch

rpmlint from Fedora ran on the xcb-utils package suggests this:

"""
xcb-util.i386: W: shared-lib-calls-exit /usr/lib/libxcb-aux.so.0.0.0 exit@GLIBC_2.0
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
"""

Perhaps the intention was to *return* something, and perhaps non-zero?
Comment 1 Peter Harris 2008-11-29 09:34:28 UTC
Thanks for the report. I've fixed this (a different way) in c9796f2.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.