Bug 20597

Summary: Blocked contacts get removed if they are removed from stored
Product: Telepathy Reporter: Marco Barisione <marco.barisione>
Component: gabbleAssignee: Will Thompson <will>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard: review+
i915 platform: i915 features:

Description Marco Barisione 2009-03-11 02:43:47 UTC 
1. Connect to a server that supports the "deny" list
2. Add a contact to your roster (he should be in subscribe and/or publish)
3. With tp-inspector add the contact do "deny"
4. Remove the contact from subscribe and publish

The contact should be left in the roster, instead he is removed.
Comment 1 Will Thompson 2010-04-28 08:49:38 UTC 
Accepting this bug.

The description above is not entirely correct: removing contacts from 'subscribe' and 'publish' doesn't remove them from deny (but has the side effect of making them vanish from 'stored', because we don't show contacts with subscription='none').

However, if you remove a contact from stored, they are indeed unblocked.
Comment 2 Will Thompson 2010-04-29 02:20:25 UTC 
I have fixed this and written a beautiful test.

(The fix is not beautiful.)

http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/dont-unblock-on-remove-0.8

http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/dont-unblock-on-remove-0.9

All the patches are the same, no-one's touched this code for a while!
Comment 4 Will Thompson 2010-04-29 06:01:19 UTC 
Merged; will be in 0.8.14 and 0.9.12!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.