Summary: | Bad error handling practice | ||
---|---|---|---|
Product: | poppler | Reporter: | Ilya Gorenbein <igorenbein> |
Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | high | ||
Version: | unspecified | ||
Hardware: | Other | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Ilya Gorenbein
2009-04-26 04:49:59 UTC
No, patch is not acceptable. Your patch still will take down the whole application, you are returning a NULL pointer that will make poppler crash. If you found any place where this is happening just fix it the proper way, that is calling the isFoo before getFoo. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.