Bug 2252

Summary: Option "DontVTSwitch" doesn't work.
Product: xorg Reporter: Egbert Eich <eich>
Component: Server/DDX/XorgAssignee: Egbert Eich <eich>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: matthieu.herrb, roland.mainz, sndirsch
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
[FIXED_X11R68x] Fix
roland.mainz: 6.8-branch+
[FIXED_X11R68x] fix for bsd_kbd.c roland.mainz: 6.8-branch+

Description Egbert Eich 2005-01-10 04:10:01 UTC
Option DontVTSwitch doesn't work due to a missing test.
Attched patch takes care of this problem.
Provided by Helmut Fahrion.
Comment 1 Egbert Eich 2005-01-10 04:10:55 UTC
Created attachment 1653 [details] [review]
[FIXED_X11R68x] Fix

Patch provided by Helmut Fahrion.
Comment 2 Egbert Eich 2005-01-10 04:20:59 UTC
2005-01-10  Egbert Eich  <eich-at-freedesktop-dot-org>

        * programs/Xserver/hw/xfree86/os-support/linux/lnx_kbd.c:
        (SpecialKey):
        Make option 'DontVTSwitch' work again with kbd driver
        under Linux.
        The kbd driver now calls the OS layer to handle special
        keys. Possibly other special keys and other OSes need to
        be looked at also.
        (Helmut Fahrion).
Comment 3 Roland Mainz 2005-01-12 15:08:58 UTC
Comment on attachment 1653 [details] [review]
[FIXED_X11R68x] Fix

Approved in the 2005-01-10 Xorg release-wranglers phone call for commit into
the X11R6.8.x stable branch.
Comment 4 Roland Mainz 2005-01-12 15:15:31 UTC
Comment on attachment 1653 [details] [review]
[FIXED_X11R68x] Fix

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.113; previous revision: 1.365.2.112
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/os-support/linux/lnx_kbd.c,v  <-- 
lnx_kbd.c
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment 5 Matthieu Herrb 2005-01-30 12:06:19 UTC
Created attachment 1791 [details] [review]
[FIXED_X11R68x] fix for bsd_kbd.c

This patch is needed for BSD systems. This code path is used only when not
using XKB.
Comment 6 Matthieu Herrb 2005-01-30 12:07:20 UTC
Reopening bug for bsd case
Comment 7 Egbert Eich 2005-01-31 07:48:33 UTC
I would support the inclusion into 6.8.2 as the validity of this fix has been
shown. We can close this ticket as the patch is committed to head already and the
nominations for 6.8.2 will be checked independently of the ticket status as we
nominate patches, not tickets.
Comment 8 Roland Mainz 2005-01-31 19:20:31 UTC
Comment on attachment 1791 [details] [review]
[FIXED_X11R68x] fix for bsd_kbd.c

Approved for commit into X11R6.8.x stable branch in the 2005-01-31 Xorg
release-wranglers phone call.
Please do not commit yourself, I'll do that myself in a few mins...
Comment 9 Roland Mainz 2005-01-31 19:33:55 UTC
Comment on attachment 1791 [details] [review]
[FIXED_X11R68x] fix for bsd_kbd.c

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  xc/ChangeLog
new revision: 1.365.2.140; previous revision: 1.365.2.139
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/os-support/bsd/bsd_kbd.c,v  <-- 
xc/programs/Xserver/hw/xfree86/os-support/bsd/bsd_kbd.c
new revision: 1.2.4.2; previous revision: 1.2.4.1
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.