Bug 23208

Summary: XV error in VLC when cropped to 16:9
Product: xorg Reporter: Martin Fry <mesa_booger>
Component: Driver/RadeonAssignee: xf86-video-ati maintainers <xorg-driver-ati>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: 7.4 (2008.09)   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
xorg log
none
VLC screenshot
none
VLC uncropped
none
VLC cropped none

Description Martin Fry 2009-08-07 14:01:35 UTC
Created attachment 28432 [details]
xorg log

Hi. Please see attached screenshot and xorg log. When I crop/zoom to 16:9 in VLC, the left hand edge does not update, but the rest is OK. So the picture is actually 16:9, but some of the left edge is missing. It looks to be the same amount as the difference between full width and the cropped version.

Not sure if this is a VLC or radeon bug. But I asked in freenode/#radeon and was advised to file this bug.
Comment 1 Martin Fry 2009-08-07 14:02:40 UTC
Created attachment 28433 [details]
VLC screenshot
Comment 2 Alex Deucher 2009-08-07 14:17:54 UTC
Do any other movie players exhibit this problem?  What does VLC's "cropping" do?  You might also try xf86-video-ati from git master there are some Xv changes there that are not in the 6.12-branch.
Comment 3 Martin Fry 2009-08-08 17:20:45 UTC
(In reply to comment #0)
> Created an attachment (id=28432) [details]
> xorg log
> 
> Hi. Please see attached screenshot and xorg log. When I crop/zoom to 16:9 in
> VLC, the left hand edge does not update, but the rest is OK. So the picture is
> actually 16:9, but some of the left edge is missing. It looks to be the same
> amount as the difference between full width and the cropped version.
> 
> Not sure if this is a VLC or radeon bug. But I asked in freenode/#radeon and
> was advised to file this bug.
> 

(In reply to comment #2)
> Do any other movie players exhibit this problem?  What does VLC's "cropping"
> do?  You might also try xf86-video-ati from git master there are some Xv
> changes there that are not in the 6.12-branch.
> 

No, only VLC has this badness. xine & *mplayer are fine. The cropping crops the edges and resizes the image to fit into a 16:9 "box" in both original player and fullscreen. As I say this might be a VLC bug, but it doesn't do that with the i810 or intel drivers, which I also tested on similar setups.
Comment 4 Alex Deucher 2009-08-09 17:36:47 UTC
(In reply to comment #3)
> No, only VLC has this badness. xine & *mplayer are fine. The cropping crops the
> edges and resizes the image to fit into a 16:9 "box" in both original player
> and fullscreen. As I say this might be a VLC bug, but it doesn't do that with
> the i810 or intel drivers, which I also tested on similar setups.
> 

vlc may use src clipping which may be broken in 6.12.x.  Can you try with xf86-video-ati from git master?
Comment 5 Martin Fry 2009-08-12 05:37:01 UTC
Created attachment 28543 [details]
VLC uncropped
Comment 6 Martin Fry 2009-08-12 05:37:46 UTC
Created attachment 28544 [details]
VLC cropped
Comment 7 Martin Fry 2009-08-12 05:40:08 UTC
Thanks.

I pulled the git xf86-video-ati master, and it seems to have cured the badness.

I made a couple of extra screenshots to show this. They are from the same frame as the previous VLC screenshot attachment.

Should I now close off this bug report, since it looks like it's been dealt with ?
Comment 8 Alex Deucher 2009-08-12 06:56:28 UTC
fixed in master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.