Bug 23283

Summary:	Implement DTMF interface support
Product:	Telepathy	Reporter:	Andre Moreira Magalhaes <andrunko>
Component:	tp-qt	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/andrunko/telepathy-qt4.git;a=shortlog;h=refs/heads/dtmf
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	23282
Bug Blocks:

Description Andre Moreira Magalhaes 2009-08-12 21:14:49 UTC

Implement DTMF interface support on StreamedMediaChannel and change callable
example CM to support simulating the DTMF interface

Comment 1 Andre Moreira Magalhaes 2009-08-24 11:21:23 UTC

telepathy-glib patch:
http://git.collabora.co.uk/?p=user/andrunko/telepathy-glib.git;a=shortlog;h=refs/heads/callable-dtmf

Comment 2 Simon McVittie 2009-08-25 05:47:03 UTC

>+dtmf_start_tone (TpSvcChannelInterfaceDTMF *iface,
>...
>+  tp_svc_channel_interface_dtmf_return_from_stop_tone (context);

Use return_from_start_tone, please (yes, I know the implementations are identical). Other than that the telepathy-glib patch looks good.

The telepathy-qt4 patches looks good too, except that you should sync the callable example with the above change.

Comment 3 Andre Moreira Magalhaes 2009-08-25 07:24:22 UTC

Fixed upstream, will be in next release 0.1.10

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.