Bug 23886

Summary: poppler fails to compile with gcc-4.4
Product: poppler Reporter: David Finkel <david.finkel>
Component: generalAssignee: poppler-bugs <poppler-bugs>
Status: RESOLVED WONTFIX QA Contact:
Severity: major    
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch against (git last commit: 68711d8494e2765c4a24ea59ce8d904981f0f917) changing several variables/parameters from char* to const char*.

Description David Finkel 2009-09-12 12:42:48 UTC 
Created attachment 29458 [details] [review]
Patch against (git last commit: 68711d8494e2765c4a24ea59ce8d904981f0f917) changing several variables/parameters from char* to const char*.

poppler both 0.12.0 and current git (fetched 2009-09-12) fail to compile with gcc-4.4, due to const char * to char * conversions.
Comment 1 Albert Astals Cid 2009-09-13 09:47:31 UTC 
that's why we use -Wno-write-strings
Comment 2 David Finkel 2009-09-16 18:45:14 UTC 
(In reply to comment #1)
> that's why we use -Wno-write-strings
> 

That only turns off warnings.  In gcc-4.4, the conversion from char* to const char* has been elevated to an error.  Considering that const char*'s are stored in what should be read-only memory, this makes sense.
Comment 3 Albert Astals Cid 2009-09-17 14:01:22 UTC 
Really? I'm using gcc 4.4.1 and it builds ok
Comment 4 Albert Astals Cid 2011-06-19 15:24:44 UTC 
As said the compilation works fine

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.