Bug 24060

Summary: shave-libtool[61]: test: argument expected when building xserver
Product: xorg Reporter: Yevgeniy <YLitvinenko>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: x86 (IA32)   
OS: Solaris   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 23613    

Description Yevgeniy 2009-09-21 02:36:42 UTC 
Error "shave-libtool[61]: test: argument" when building xserver

I think it is better to add quotation marks into shave.in and shave-libtool.in

$ diff -u shave-libtool.in shave-libtool.in_mod
--- shave-libtool.in    Mon Sep 21 14:58:39 2009
+++ shave-libtool.in_mod        Mon Sep 21 15:25:08 2009
@@ -58,7 +58,7 @@
 lt_unmangle "$lt_output"
 output=$last_result

-if test -z $V; then
+if test -z "$V"; then
     if test $pass_though -eq 0; then
         echo "$Q$output"
     fi


$ diff -u shave.in shave.in_mod
--- shave.in    Mon Sep 21 14:58:39 2009
+++ shave.in_mod        Mon Sep 21 15:25:22 2009
@@ -75,7 +75,7 @@
 lt_unmangle "$lt_output"
 output=$last_result

-if test -z $V; then
+if test -z "$V"; then
     if test $pass_through -eq 0; then
         echo "$Q$output"
     fi


Or add #!/bin/bash instead of #!/bin/sh at the begining of the files
Comment 1 Peter Hutterer 2009-09-27 22:13:52 UTC 
Fixed with 0c2731596f27f2cdf5000ba41de37e7eb86ad6f9, thanks for reporting!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.