Bug 25160

Summary: New media spec implementation needs to support relay servers
Product: Telepathy Reporter: Sjoerd Simons <sjoerd>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium CC: cmaiku
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/maiku/telepathy-gabble.git;a=shortlog;h=refs/heads/relay
Whiteboard:
i915 platform: i915 features:

Description Sjoerd Simons 2009-11-18 03:55:35 UTC
See subject, maiku has a branch at the given url
Comment 1 Sjoerd Simons 2009-11-18 04:08:35 UTC
Comments on the branch:
* gabble_call_stream_add_candidates comes from dbus, don't assert that gabble if something in 
  the dbus message isn't valid. You should treat dbus messages just like network traffic basically
* same comments as the stun server branch for the test

Also, don't these two branch conflict if we would merge them ? Might have been better to stack the turn branch on top of the stun branch
Comment 2 Mike Ruprecht 2009-11-18 13:36:48 UTC
Updated the branch per your review.
Comment 3 Sjoerd Simons 2009-11-19 04:04:11 UTC
5df0eb2430e9ade8b3eadf24250ba7c2438504c6.
   assertEquals wrong way round

looks good otherwise
Comment 4 Mike Ruprecht 2009-11-19 13:20:54 UTC
Updated the branch per your review.
Comment 5 Sjoerd Simons 2009-11-20 03:22:11 UTC
merged thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.