Bug 25659

Summary: ObserveChannels implementation might actually return immediately
Product: Telepathy Reporter: Will Thompson <will>
Component: tp-qtAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Will Thompson 2009-12-15 11:38:48 UTC 
While learning more about how to implement services with QtDBus, I noticed that TpQt4 doesn't call setDelayedReply(true) on the DBusMessage; from my reading of the documentation, this means that ObserveChannels() is returning immediately, rather than waiting for the library user's implementation to signal that it's ready to return from ObserveChannels(). We should check if this actually works.

(Thiago Macieira informs us that having a DBusMessage argument in the adaptor's method implementation is deprecated—in some nebulous fashion which does not involve marking it as such in the documentation :-)—in favour of the exported object (not adaptor) deriving from DBusContext and calling magic methods to get the current connection and message, etc. But possibly switching to that is orthogonal to checking this potential bug out.)
Comment 1 Andre Moreira Magalhaes 2010-02-22 07:24:28 UTC 
Fixed. It will be in release 0.2.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.