Bug 25989 (gabble-decloak)

Summary:	Decloaking/"smoking out" presence
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	gabble	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/decloak-api
Whiteboard:
i915 platform:		i915 features:

Description Simon McVittie 2010-01-11 06:35:08 UTC

As discussed on the XMPP standards list, here's an implementation of decloaking as proposed by Rob McQueen and Peter St.Andre.

There are three branches involved, it would be worthwhile to review any or all:

* lm-vs-wocky notes an inconsistency in behaviour between genuine Loudmouth and our Loudmouth emulation layer, fixes the presence cache to work correctly with the emulation layer, and makes the emulation layer assert in cases where it would previously just not work right

* decloak is based on lm-vs-wocky, and implements both sides of the decloaking proto-XEP (caller and receiver).

* decloak-api adds a simple Gabble-specific D-Bus API to indicate when people want to decloak us, etc.

Comment 1 Simon McVittie 2010-01-21 10:00:56 UTC

Please review in this order:

http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/lm-vs-wocky

http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/decloak

http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/decloak-api

Comment 2 Simon McVittie 2010-01-22 08:20:14 UTC

Fixed in git, will be in 0.9.4.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.