Bug 26117

Summary:	Add Call interface support to StreamedMediaChannel
Product:	Telepathy	Reporter:	Andre Moreira Magalhaes <andrunko>
Component:	tp-qt	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/andrunko/telepathy-qt4.git;a=shortlog;h=refs/heads/call
Whiteboard:
i915 platform:		i915 features:

Description Andre Moreira Magalhaes 2010-01-19 06:16:57 UTC

Add Call interface support alongside StreamedMedia interface support to StreamedMediaChannel class.

The idea is to keep old methods working and add new methods to support Call interface. The old methods will be marked deprecated and be removed in a new stable version.

The initial patch refactors StreamedMediaChannel to prepare it to support the Call interface.

Comment 1 Simon McVittie 2010-01-19 06:39:40 UTC

>     MediaContentPtr content() const;
> 
>     TELEPATHY_QT4_DEPRECATED StreamedMediaChannelPtr channel() const;

Why is this deprecated? Even if it's just a shortcut for content()->channel(),
it seems a reasonable thing to want to do, and is non-lossy.

>     SendingState localSendingState() const;
>     SendingState remoteSendingState(const ContactPtr &contact) const;
> 
>     TELEPATHY_QT4_DEPRECATED bool sending() const;

Why is this deprecated? It looks as though it should just expand to
(localSendingState() == SendingStateSending) which seems perfectly reasonable.

>     TELEPATHY_QT4_DEPRECATED bool receiving() const;
>     TELEPATHY_QT4_DEPRECATED bool localSendingRequested() const;
>     TELEPATHY_QT4_DEPRECATED bool remoteSendingRequested() const;

Likewise for these?

>     TELEPATHY_QT4_DEPRECATED MediaStreamDirection direction() const;
>     TELEPATHY_QT4_DEPRECATED MediaStreamPendingSend pendingSend() const;

I can see the logic in deprecating these, though; they're combining things that
don't necessarily make sense to combine.

Comment 2 Andre Moreira Magalhaes 2010-03-16 20:32:07 UTC

Merged upstream. It will be included in next version 0.3.0

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.