Summary: | Compilation fails on Solaris due to missing -lrt for nanosleep | ||
---|---|---|---|
Product: | poppler | Reporter: | Fabian Groffen <grobian> |
Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Solaris | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Fabian Groffen
2010-02-19 07:59:14 UTC
Can you: a) provide access to an opensolaris system for testing? or b) test patches? s/opensolaris/solaris 10/ I have access to opensolaris/Intel, Solaris 10/Intel and Solaris 10/Sparc, and can easily test, but cannot provide access to them. Easiest for you to test out stuff would be to quickly install (open)solaris in e.g. a virtual box instance. I worked around the issue for now by exporting LDFLAGS=-lrt on Solaris while compiling. Can you please test this patch? diff --git a/ConfigureChecks.cmake b/ConfigureChecks.cmake index 6049c9a..04de970 100644 --- a/ConfigureChecks.cmake +++ b/ConfigureChecks.cmake @@ -49,3 +49,8 @@ check_for_dir("dirent.h" HAVE_DIRENT_H) check_for_dir("ndir.h" HAVE_NDIR_H) check_for_dir("sys/dir.h" HAVE_SYS_DIR_H) check_for_dir("sys/ndir.h" HAVE_SYS_NDIR_H) + +check_function_exists("nanosleep" HAVE_NANOSLEEP) +if(NOT HAVE_NANOSLEEP) + check_library_exists("rt" "nanosleep" "" LIB_RT_HAS_NANOSLEEP) +endif(NOT HAVE_NANOSLEEP) diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 2c6ec36..eada899 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -1,12 +1,17 @@ if (ENABLE_SPLASH) - set (perf_test_SRCS - perf-test.cc - perf-test-preview-dummy.cc - ) - add_executable(perf-test ${perf_test_SRCS}) - target_link_libraries(perf-test poppler) + if (HAVE_NANOSLEEP OR LIB_RT_HAS_NANOSLEEP) + set (perf_test_SRCS + perf-test.cc + perf-test-preview-dummy.cc + ) + add_executable(perf-test ${perf_test_SRCS}) + target_link_libraries(perf-test poppler) + if (LIB_RT_HAS_NANOSLEEP) + target_link_libraries(perf-test rt) + endif (LIB_RT_HAS_NANOSLEEP) + endif (HAVE_NANOSLEEP OR LIB_RT_HAS_NANOSLEEP) endif (ENABLE_SPLASH) ... -- Looking for nanosleep -- Looking for nanosleep - not found -- Looking for nanosleep in rt -- Looking for nanosleep in rt - found ... And it completes its build. So patch looks good to me! Will be in next 0.13.x release |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.