Bug 89132

Summary: [SKL mobile]eDP screen flicker after system resume from s4
Product: DRI Reporter: liulei <lei.a.liu>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: major    
Priority: high CC: intel-gfx-bugs
Version: unspecified   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg none

Description liulei 2015-02-13 07:09:51 UTC
Created attachment 113452 [details]
dmesg

==System Environment==
--------------------------
Bios : V68
Regression: No. First test on this platform.
Non-working platforms: SKLY

==kernel==
--------------------------
-nightly: b4442ee4e150506cebeee72249efc566c5f14bbe (fails)
     drm-intel-nightly: 2015y-02m-06d-09h-25m-00s UTC integration manifest

==Bug detailed description==
-----------------------------
eDP screen flicker after system resume from s4.

==Reproduce steps==
---------------------------- 
1. boot OS up
2. do s4
3. check eDP monitor
Comment 2 Jani Nikula 2015-02-13 08:37:33 UTC
[    3.520344] ------------[ cut here ]------------
[    3.520399] WARNING: CPU: 0 PID: 24 at drivers/gpu/drm/i915/intel_pm.c:3084 skl_update_other_pipe_wm+0xe3/0x156 [i915]()
[    3.520401] WARN_ON(!wm_changed)
[    3.520423] Modules linked in: i915 button video drm_kms_helper drm cfbfillrect cfbimgblt cfbcopyarea
[    3.520428] CPU: 0 PID: 24 Comm: kworker/u16:1 Not tainted 3.19.0-rc7_drm-intel-nightly_b4442e_20150208+ #198
[    3.520430] Hardware name: Intel Corporation Skylake Client platform/Skylake Y LPDDR3 RVP3, BIOS SKLSE2R1.86C.B068.R00.1501090908 01/09/2015
[    3.520438] Workqueue: events_unbound async_run_entry_fn
[    3.520442]  0000000000000000 0000000000000009 ffffffff8179a69b ffff880148dbf5a8
[    3.520445]  ffffffff8103bdec ffff880143cb991c ffffffffa008d5f4 ffffffff81b88000
[    3.520447]  ffff880143cb9918 ffff880148dbf670 ffff880143dcf000 ffff88009bbce000
[    3.520448] Call Trace:
[    3.520456]  [<ffffffff8179a69b>] ? dump_stack+0x40/0x50
[    3.520462]  [<ffffffff8103bdec>] ? warn_slowpath_common+0x98/0xb0
[    3.520502]  [<ffffffffa008d5f4>] ? skl_update_other_pipe_wm+0xe3/0x156 [i915]
[    3.520507]  [<ffffffff8103be9c>] ? warn_slowpath_fmt+0x45/0x4a
[    3.520543]  [<ffffffffa008d5f4>] ? skl_update_other_pipe_wm+0xe3/0x156 [i915]
[    3.520576]  [<ffffffffa008d7a6>] ? skl_update_wm+0x13f/0x5a8 [i915]
[    3.520587]  [<ffffffff81065284>] ? add_wait_queue+0x3c/0x3c
[    3.520657]  [<ffffffffa00f735b>] ? intel_dp_aux_transfer+0x11a/0x142 [i915]
[    3.520719]  [<ffffffffa00d8ee3>] ? haswell_crtc_disable+0x29d/0x30b [i915]
[    3.520810]  [<ffffffffa00d93d7>] ? __intel_set_mode+0x344/0x895 [i915]
[    3.520870] [drm:gen8_irq_handler [i915]] *ERROR* CPU pipe A FIFO underrun
[    3.520931]  [<ffffffffa00df2d3>] ? intel_crtc_set_config+0x7d0/0xbb9 [i915]
[    3.520953]  [<ffffffffa0024a11>] ? drm_atomic_state_clear+0xec/0x10d [drm]
[    3.520967]  [<ffffffffa001804a>] ? drm_mode_set_config_internal+0x4e/0xd2 [drm]
[    3.520973]  [<ffffffffa00652e2>] ? restore_fbdev_mode+0xa8/0xc3 [drm_kms_helper]
[    3.520978]  [<ffffffffa00665ff>] ? drm_fb_helper_restore_fbdev_mode_unlocked+0x1f/0x56 [drm_kms_helper]
[    3.520983]  [<ffffffffa0066664>] ? drm_fb_helper_set_par+0x2e/0x33 [drm_kms_helper]
[    3.521042]  [<ffffffffa00eb9fa>] ? intel_fb_initial_config+0x4d1/0x4d1 [i915]
[    3.521110]  [<ffffffffa00eba0b>] ? intel_fbdev_set_par+0x11/0x55 [i915]
[    3.521118]  [<ffffffff81379efd>] ? fbcon_init+0x2ff/0x408
[    3.521122]  [<ffffffff813cca71>] ? visual_init+0xaf/0x102
[    3.521126]  [<ffffffff813ce20d>] ? do_bind_con_driver+0x1a1/0x2ca
[    3.521129]  [<ffffffff813ce468>] ? do_take_over_console+0x132/0x162
[    3.521133]  [<ffffffff813795ea>] ? do_fbcon_takeover+0x53/0x96
[    3.521137]  [<ffffffff81051935>] ? notifier_call_chain+0x2e/0x59
[    3.521142]  [<ffffffff81051a74>] ? __blocking_notifier_call_chain+0x43/0x5d
[    3.521145]  [<ffffffff81382f73>] ? register_framebuffer+0x23f/0x29d
[    3.521151]  [<ffffffffa00668bb>] ? drm_fb_helper_initial_config+0x252/0x2ef [drm_kms_helper]
[    3.521155]  [<ffffffff81052a9b>] ? async_run_entry_fn+0x2d/0xc3
[    3.521160]  [<ffffffff8104d128>] ? process_one_work+0x1ad/0x31a
[    3.521165]  [<ffffffff8104d4ef>] ? worker_thread+0x235/0x330
[    3.521169]  [<ffffffff8104d2ba>] ? process_scheduled_works+0x25/0x25
[    3.521172]  [<ffffffff81050dee>] ? kthread+0xc5/0xcd
[    3.521176]  [<ffffffff81050d29>] ? kthread_freezable_should_stop+0x40/0x40
[    3.521179]  [<ffffffff8179ffec>] ? ret_from_fork+0x7c/0xb0
[    3.521183]  [<ffffffff81050d29>] ? kthread_freezable_should_stop+0x40/0x40
[    3.521185] ---[ end trace 8123ccd83fef64b5 ]---
Comment 3 Jesse Barnes 2015-03-31 18:28:06 UTC
Is this still an issue with current bits?  IIRC Damien found that we weren't restoring clocks correctly, but I'm not sure if that's fixed.
Comment 4 liulei 2015-04-02 05:26:10 UTC
This issue still exists on latest -nightly.
Comment 5 liulei 2015-04-02 05:32:21 UTC
(In reply to liulei from comment #4)
> This issue still exists on latest -nightly.

Wrong typo.

This issue doesn't exist on latest -nightly. So close this one.
Comment 6 Jari Tahvanainen 2016-10-10 10:41:21 UTC
Closing verified+fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.