Attachment 116574 Details for Bug 90979 – Ignore VBT if BIOS enables the LVDS pin

[patch] Ignore VBT if BIOS enables the LVDS pin

lvds.patch (text/plain), 1.01 KB, created by Chris Wilson on 2015-06-18 08:02:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2015-06-18 08:02:06 UTC

Size: 1.01 KB

patch

obsolete

>diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
>index 161ab26f81fb..c439508067f6 100644
>--- a/drivers/gpu/drm/i915/intel_lvds.c
>+++ b/drivers/gpu/drm/i915/intel_lvds.c
>@@ -942,12 +942,6 @@ void intel_lvds_init(struct drm_device *dev)
> 	if (dmi_check_system(intel_no_lvds))
> 		return;
> 
>-	pin = GMBUS_PIN_PANEL;
>-	if (!lvds_is_present_in_vbt(dev, &pin)) {
>-		DRM_DEBUG_KMS("LVDS is not present in VBT\n");
>-		return;
>-	}
>-
> 	if (HAS_PCH_SPLIT(dev)) {
> 		if ((I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
> 			return;
>@@ -957,6 +951,16 @@ void intel_lvds_init(struct drm_device *dev)
> 		}
> 	}
> 
>+	pin = GMBUS_PIN_PANEL;
>+	if (!lvds_is_present_in_vbt(dev, &pin)) {
>+		u32 reg = HAS_PCH_SPLIT(dev) ? PCH_LVDS : LVDS;
>+		if ((I915_READ(reg) & LVDS_PORT_EN) == 0) {
>+			DRM_DEBUG_KMS("LVDS is not present in VBT\n");
>+			return false;
>+		}
>+		DRM_DEBUG_KMS("LVDS is not present in VBT, but enabled anyway\n");
>+	}
>+
> 	lvds_encoder = kzalloc(sizeof(*lvds_encoder), GFP_KERNEL);
> 	if (!lvds_encoder)
> 		return;

Actions: View | Splinter Review

Attachments on bug 90979: 116495 | 116500 | 116565 | 116574

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.