Attachment 1802 Details for Bug 2436 – possible fix

[patch] possible fix

dbus-session-connect.patch (text/plain), 1.92 KB, created by Havoc Pennington on 2005-01-31 15:51:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Havoc Pennington

Created: 2005-01-31 15:51:03 UTC

Size: 1.92 KB

patch

obsolete

>Index: ChangeLog
>===================================================================
>RCS file: /cvs/dbus/dbus/ChangeLog,v
>retrieving revision 1.678
>diff -u -p -u -r1.678 ChangeLog
>--- ChangeLog	31 Jan 2005 23:17:18 -0000	1.678
>+++ ChangeLog	31 Jan 2005 23:49:56 -0000
>@@ -1,5 +1,14 @@
> 2005-01-31  Havoc Pennington  <hp@redhat.com>
> 
>+	* bus/policy.c (bus_policy_allow_user): change default "user is
>+	allowed" to be "user has same uid as the bus itself or is root";
>+	any allow/deny rules will override.
>+
>+	* bus/session.conf.in: don't allow all users, since now by default
>+	the user that ran the bus can connect.
>+
>+2005-01-31  Havoc Pennington  <hp@redhat.com>
>+
> 	* glib/dbus-gproxy.c: rewrite how signals work again, this time I
> 	think it's sort of right
> 
>Index: bus/policy.c
>===================================================================
>RCS file: /cvs/dbus/dbus/bus/policy.c,v
>retrieving revision 1.22
>diff -u -p -u -r1.22 policy.c
>--- bus/policy.c	25 Aug 2004 22:11:49 -0000	1.22
>+++ bus/policy.c	31 Jan 2005 23:49:56 -0000
>@@ -453,8 +453,9 @@ bus_policy_allow_user (BusPolicy        
>                      uid);
>       return FALSE;
>     }
>-  
>-  allowed = FALSE;
>+
>+  /* Default to "user owning bus" or root can connect */
>+  allowed = (uid = _dbus_getuid ()) || uid == 0;
> 
>   allowed = list_allows_user (allowed,
>                               &policy->default_rules,
>Index: bus/session.conf.in
>===================================================================
>RCS file: /cvs/dbus/dbus/bus/session.conf.in,v
>retrieving revision 1.8
>diff -u -p -u -r1.8 session.conf.in
>--- bus/session.conf.in	25 Oct 2004 18:48:58 -0000	1.8
>+++ bus/session.conf.in	31 Jan 2005 23:49:56 -0000
>@@ -19,8 +19,6 @@
>     <allow eavesdrop="true"/>
>     
>     <allow own="*"/>
>-    
>-    <allow user="*"/>
>   </policy>
> 
>   <!-- This is included last so local configuration can override what's

Actions: View | Splinter Review

Attachments on bug 2436: 1802 | 1803

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.