Attachment 29109 Details for Bug 23576 – 0002-ARM-Remove-fallback-to-ARMv6-implementation-from-NE.patch

[patch] 0002-ARM-Remove-fallback-to-ARMv6-implementation-from-NE.patch

0002-ARM-Remove-fallback-to-ARMv6-implementation-from-NE.patch (text/plain), 1.49 KB, created by Siarhei Siamashka on 2009-09-02 10:07:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Siarhei Siamashka

Created: 2009-09-02 10:07:21 UTC

Size: 1.49 KB

patch

obsolete

>From 186a234a19f74c9a891a630af33ee34c061fc314 Mon Sep 17 00:00:00 2001
>From: Siarhei Siamashka <siarhei.siamashka@nokia.com>
>Date: Wed, 2 Sep 2009 19:46:47 +0300
>Subject: [PATCH] ARM: Remove fallback to ARMv6 implementation from NEON delegate chain
>
>This can help to fix build problems with '-mthumb' gcc option in CFLAGS.
>ARMv6 optimized code can't be compiled for thumb (because of its inline
>assembly) and gets automatically disabled in configure. Reference
>to it from NEON optimized code resulted in linking problems.
>
>Every ARMv6 optimized fast path function also has a better NEON
>counterpart, so there is no need to fallback to ARMv6. Shorter
>delegate chain should additionally result in a bit better performance.
>---
> pixman/pixman-arm-neon.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/pixman/pixman-arm-neon.c b/pixman/pixman-arm-neon.c
>index 3e7f566..8a2d72e 100644
>--- a/pixman/pixman-arm-neon.c
>+++ b/pixman/pixman-arm-neon.c
>@@ -2767,8 +2767,8 @@ arm_neon_fill (pixman_implementation_t *imp,
> pixman_implementation_t *
> _pixman_implementation_create_arm_neon (void)
> {
>-    pixman_implementation_t *simd = _pixman_implementation_create_arm_simd ();
>-    pixman_implementation_t *imp = _pixman_implementation_create (simd);
>+    pixman_implementation_t *general = _pixman_implementation_create_fast_path ();
>+    pixman_implementation_t *imp = _pixman_implementation_create (general);
> 
>     imp->composite = arm_neon_composite;
> #if 0 /* this code has some bugs */
>-- 
>1.5.4.3
>

Actions: View | Splinter Review

Attachments on bug 23576: 28986 | 29109

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.