Attachment 31969 Details for Bug 25578 – Propsed Patch

[patch] Propsed Patch

poppler-fix.txt (text/plain), 1016 bytes, created by Amit on 2009-12-10 23:05:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Amit

Created: 2009-12-10 23:05:23 UTC

Size: 1016 bytes

patch

obsolete

>poppler/goo/FixedPoint.cc
>
>Old Code
>---int FixedPoint::mul(int x, int y) {
>#if 1 //~tmp
>  return ((FixPtInt64)x * y) >> fixptShift;
>
>New Changes
>+++
>FixPtInt64 FixedPoint::mul(FixPtInt64 x, FixPtInt64 y) {
>#if 1 //~tmp
>  FixPtInt64 val;
>  val =((FixPtInt64)(x * y))>>fixptShift;
>
>  return val;
>
>
>poppler/goo/FixedPoint.h
>
>OldCode
>--static FixedPoint make(int valA) { FixedPoint x; x.val = valA; return x; }
>
>New changes
>++  static FixedPoint make(FixPtInt64 valA) { FixedPoint x; x.val = valA; return x; }
>
>--  static int mul(int x, int y);
>++  static FixPtInt64 mul(FixPtInt64 x, FixPtInt64 y);
>
>
>--  static int div(int x, int y);
>++  static FixPtInt64 div(FixPtInt64 x, FixPtInt64 y);
>
>--  int val;			// 16.16 fixed point
>++  FixPtInt64 val;		// 16.16 fixed point
>
>--  int FixedPoint::div(int x, int y) {
>--  #if 1 //~tmp
>--   return ((FixPtInt64)x << fixptShift) / y;
>
>++ int FixedPoint::div(int x, int y) {
>++ #if 1 //~tmp
>++ if(y>0)
>++    return ((FixPtInt64)x << fixptShift) / y;
>++  else 
>++    return 0;
>++

Actions: View | Splinter Review

Attachments on bug 25578: 31969 | 32429

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.