Attachment 38362 Details for Bug 29943 – Give the correct type to the debug_sender global variable.

[patch] Give the correct type to the debug_sender global variable.

0001-Give-the-correct-type-to-the-debug_sender-global-var.patch (text/plain), 1.29 KB, created by Olivier Crête on 2010-09-01 10:42:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Crête

Created: 2010-09-01 10:42:30 UTC

Size: 1.29 KB

patch

obsolete

>From 84c12ee3ea083186bc3fc1ff2b2b9d606eae02c1 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Olivier=20Cr=C3=AAte?= <olivier.crete@collabora.co.uk>
>Date: Wed, 1 Sep 2010 13:37:22 -0400
>Subject: [PATCH 1/2] Give the correct type to the debug_sender global variable.
>
>There is no reason to make it a gpointer while we have the correct type
>available.
>---
> telepathy-glib/debug-sender.c |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/telepathy-glib/debug-sender.c b/telepathy-glib/debug-sender.c
>index 75aa282..4e4aa8d 100644
>--- a/telepathy-glib/debug-sender.c
>+++ b/telepathy-glib/debug-sender.c
>@@ -65,7 +65,7 @@
>  * Since: 0.7.36
>  */
> 
>-static gpointer debug_sender = NULL;
>+static TpDebugSender *debug_sender = NULL;
> 
> /* On the basis that messages are around 60 bytes on average, and that 50kb is
>  * a reasonable maximum size for a frame buffer.
>@@ -205,8 +205,8 @@ tp_debug_sender_constructor (GType type,
>     {
>       retval = G_OBJECT_CLASS (tp_debug_sender_parent_class)->constructor (
>           type, n_construct_params, construct_params);
>-      debug_sender = retval;
>-      g_object_add_weak_pointer (retval, &debug_sender);
>+      debug_sender = TP_DEBUG_SENDER (retval);
>+      g_object_add_weak_pointer (retval, (gpointer *) &debug_sender);
>     }
>   else
>     {
>-- 
>1.7.2.2
>

Actions: View | Splinter Review

Attachments on bug 29943: 38362 | 38363 | 38364 | 38365

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.