Attachment 38779 Details for Bug 30251 – Fix the split media handling in PackageKit yum backend

[patch] Fix the split media handling in PackageKit yum backend

splitmedia.patch (text/plain), 1.59 KB, created by Hedayat Vatankhah on 2010-09-18 03:40:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hedayat Vatankhah

Created: 2010-09-18 03:40:04 UTC

Size: 1.59 KB

patch

obsolete

>--- Ø¯Ø§ÙÙÙÙØ¯/backends_yum_yumBackend.py	2010-09-18 13:48:10.725156363 +0430
>+++ yumBackend.py	2010-09-18 13:50:42.662383212 +0430
>@@ -3292,7 +3278,7 @@
>             else:
>                 raise PkError(ERROR_INTERNAL_ERROR, _format_str(traceback.format_exc()))
> 
>-    def _media_find_root(self, media_id, disc_number=1):
>+    def _media_find_root(self, media_id, disc_number=-1):
>         """ returns the root "/media/Fedora Extras" or None """
> 
>         # search all the disks
>@@ -3322,13 +3308,14 @@
>                 continue
> 
>             # disc number can be random things like 'ALL'
>-            disc_number_tmp = 1
>-            try:
>-                disc_number_tmp = int(lines[3].strip())
>-            except ValueError, e:
>-                pass
>-            if disc_number_tmp != disc_number:
>-                continue
>+            if disc_number != -1:
>+                disc_number_tmp = 1
>+                try:
>+                    disc_number_tmp = int(lines[3].strip())
>+                except ValueError, e:
>+                    pass
>+                if disc_number_tmp != disc_number:
>+                    continue
>             return root
> 
>         # nothing remaining
>@@ -3351,7 +3338,7 @@
> 
>         # we have to send a message to the client
>         if not root:
>-            name = kwargs["name"]
>+            name = "%s Volume #%s" %(kwargs["name"], kwargs["discnum"])
>             self.backend.media_change_required(MEDIA_TYPE_DISC, name, name)
>             self.backend.error(ERROR_MEDIA_CHANGE_REQUIRED,
>                                "Insert media labeled '%s' or disable media repos" % name,

Actions: View | Splinter Review

Attachments on bug 30251: 38779

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.