Attachment 43487 Details for Bug 34378 – workaround

[patch] workaround

0001-st-mesa-always-re-bind-vertex-arrays.patch (text/plain), 1.29 KB, created by Marek Olšák on 2011-02-17 07:28:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marek Olšák

Created: 2011-02-17 07:28:16 UTC

Size: 1.29 KB

patch

obsolete

>From f506344a2392ac9e30f6c1118d9f639b5017f048 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marek=20Ol=C5=A1=C3=A1k?= <maraeo@gmail.com>
>Date: Thu, 17 Feb 2011 16:17:34 +0100
>Subject: [PATCH] st/mesa: always re-bind vertex arrays
>
>This is a temporary workaround.
>
>I guess we might be changing vertex attribs somewhere and not updating
>the appropriate dirty flags, therefore we can't rely on them for now.
>Or maybe we need to make this state dependent on some other flags too.
>
>More info:
>https://bugs.freedesktop.org/show_bug.cgi?id=34378
>---
> src/mesa/state_tracker/st_draw.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c
>index 830e3e3..5475e87 100644
>--- a/src/mesa/state_tracker/st_draw.c
>+++ b/src/mesa/state_tracker/st_draw.c
>@@ -613,8 +613,10 @@ st_draw_vbo(struct gl_context *ctx,
>    struct pipe_index_buffer ibuffer;
>    struct pipe_draw_info info;
>    unsigned i;
>+   GLboolean new_array = GL_TRUE;
>+   /* Fix this (Bug 34378):
>    GLboolean new_array =
>-         st->dirty.st && (st->dirty.mesa & (_NEW_ARRAY | _NEW_PROGRAM)) != 0;
>+         st->dirty.st && (st->dirty.mesa & (_NEW_ARRAY | _NEW_PROGRAM)) != 0;*/
> 
>    /* Mesa core state should have been validated already */
>    assert(ctx->NewState == 0x0);
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 34378: 43487

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.