Attachment 56603 Details for Bug 45625 – [PATCH] cnf: Quote the arguments passed to pk-command-not-found

[patch] [PATCH] cnf: Quote the arguments passed to pk-command-not-found

-cnf-Quote-the-arguments-passed-to-pk-command-not-found.patch (text/plain), 1.01 KB, created by Dan Nicholson on 2012-02-04 10:38:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dan Nicholson

Created: 2012-02-04 10:38:33 UTC

Size: 1.01 KB

patch

obsolete

>From ee0db3e6dbbee2356cad8557857fdb7e27cb8d0c Mon Sep 17 00:00:00 2001
>From: Dan Nicholson <dbn.lists@gmail.com>
>Date: Sat, 4 Feb 2012 09:16:12 -0800
>Subject: [PATCH] cnf: Quote the arguments passed to pk-command-not-found
>
>"$@" is a special variable in bash that expands to all the positional
>parameters properly quoted. Essentially it means that any parameters
>with spaces will be passed correctly as a single argument.
>---
> contrib/command-not-found/PackageKit.sh.in |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/contrib/command-not-found/PackageKit.sh.in b/contrib/command-not-found/PackageKit.sh.in
>index 96cd816..5d2736f 100644
>--- a/contrib/command-not-found/PackageKit.sh.in
>+++ b/contrib/command-not-found/PackageKit.sh.in
>@@ -18,7 +18,7 @@ command_not_found_handle () {
> 
> 	# run the command, or just print a warning
> 	if [ $runcnf -eq 1 ]; then
>-		@LIBEXECDIR@/pk-command-not-found $@
>+		@LIBEXECDIR@/pk-command-not-found "$@"
> 		retval=$?
> 	else
> 		echo "bash: $1: command not found"
>-- 
>1.7.7.6
>

Actions: View | Splinter Review

Attachments on bug 45625: 56602 | 56603 | 56604 | 56605 | 56606 | 56607

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.