Attachment 56605 Details for Bug 45625 – [PATCH] cnf: Only search for packages when shell is interactive

[patch] [PATCH] cnf: Only search for packages when shell is interactive

-cnf-Only-search-for-packages-when-shell-is-interactive.patch (text/plain), 1.15 KB, created by Dan Nicholson on 2012-02-04 10:38:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dan Nicholson

Created: 2012-02-04 10:38:42 UTC

Size: 1.15 KB

patch

obsolete

>From 0a880d7d134e0023a1534804859cb8b277deda58 Mon Sep 17 00:00:00 2001
>From: Dan Nicholson <dbn.lists@gmail.com>
>Date: Sat, 4 Feb 2012 09:34:31 -0800
>Subject: [PATCH] cnf: Only search for packages when shell is interactive
>
>If we're inside a script, we can't ask a user to install a package, so
>just return with an error. Example:
>
>$ banshee
>-bash: banshee: command not found
>Install package 'banshee' to provide command 'banshee'? [N/y]
>$ bash -c '. /etc/profile.d/PackageKit.sh; banshee'
>bash: banshee: command not found
>---
> contrib/command-not-found/PackageKit.sh.in |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>diff --git a/contrib/command-not-found/PackageKit.sh.in b/contrib/command-not-found/PackageKit.sh.in
>index bb39c8b..3097a39 100644
>--- a/contrib/command-not-found/PackageKit.sh.in
>+++ b/contrib/command-not-found/PackageKit.sh.in
>@@ -15,6 +15,9 @@ command_not_found_handle () {
> 	fmt=$(gettext bash "%s: command not found")
> 	printf "%s: $fmt\n" "$0" "$1"
> 
>+	# only search for the command if we're interactive
>+	[[ $- =~ i ]] || runcnf=0
>+
> 	# don't run if DBus isn't running
> 	[ ! -S /var/run/dbus/system_bus_socket ] && runcnf=0
> 
>-- 
>1.7.7.6
>

Actions: View | Splinter Review

Attachments on bug 45625: 56602 | 56603 | 56604 | 56605 | 56606 | 56607

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.