Attachment 57597 Details for Bug 43751 – Downgrade ERROR message

[patch] Downgrade ERROR message

0001-drm-i915-bios-Downgrade-the-signature-missing-DRM_ER.patch (text/plain), 1.08 KB, created by Chris Wilson on 2012-02-24 08:58:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2012-02-24 08:58:57 UTC

Size: 1.08 KB

patch

obsolete

>From d8bc8a468a40489f0fa5e49665c84d58ed56a329 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Fri, 24 Feb 2012 16:50:37 +0000
>Subject: [PATCH] drm/i915/bios: Downgrade the "signature missing" DRM_ERROR
> to debug
>
>As we warn the user later that we cannot find or load the VBIOS,
>explaining why is an exercise in debugging. Shouting *ERROR* upsets
>people and produces bug reports.
>
>Reported-by: Michael Rieder <mr@student.ethz.ch>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43751
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/intel_bios.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
>index 5065633..8168d8f 100644
>--- a/drivers/gpu/drm/i915/intel_bios.c
>+++ b/drivers/gpu/drm/i915/intel_bios.c
>@@ -669,7 +669,7 @@ intel_parse_bios(struct drm_device *dev)
> 		}
> 
> 		if (!vbt) {
>-			DRM_ERROR("VBT signature missing\n");
>+			DRM_DEBUG_DRIVER("VBT signature missing\n");
> 			pci_unmap_rom(pdev, bios);
> 			return -1;
> 		}
>-- 
>1.7.9.1
>

Actions: View | Splinter Review

Attachments on bug 43751: 57597

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.