Attachment 71147 Details for Bug 57988 – Quick fix

[patch] Quick fix

0001-drm-nouveau-set-legacy-bios-data-before-parsing-the-.patch (text/plain), 1.38 KB, created by Emil Velikov on 2012-12-07 17:29:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emil Velikov

Created: 2012-12-07 17:29:21 UTC

Size: 1.38 KB

patch

obsolete

>From 35ef2e499675a9e6956e19d5e7769fb018d871ee Mon Sep 17 00:00:00 2001
>From: Emil Velikov <emil.l.velikov@gmail.com>
>Date: Fri, 7 Dec 2012 17:26:44 +0000
>Subject: [PATCH] drm/nouveau: set legacy bios data before parsing the
> structure
>
>Commit 767baf82 drm/nouveau: remove some more unnecessary legacy bios code
>
>has introduced a regression my misplacing the code that sets the major/chip
>versions, which are used whist parsing the bmp/bit structure in vbios
>
>Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
>---
> drivers/gpu/drm/nouveau/nouveau_bios.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
>index 5e1cfca..235de99 100644
>--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
>+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
>@@ -2008,6 +2008,8 @@ static bool NVInitVBIOS(struct drm_device *dev)
> 
> 	legacy->data = bios->data;
> 	legacy->length = bios->size;
>+	legacy->major_version = bios->version.major;
>+	legacy->chip_version = bios->version.chip;
> 	if (bios->bit_offset) {
> 		legacy->type = NVBIOS_BIT;
> 		legacy->offset = bios->bit_offset;
>@@ -2019,8 +2021,6 @@ static bool NVInitVBIOS(struct drm_device *dev)
> 		return !parse_bmp_structure(dev, legacy, legacy->offset);
> 	}
> 
>-	legacy->major_version = bios->version.major;
>-	legacy->chip_version = bios->version.chip;
> 	return false;
> }
> 
>-- 
>1.8.0.1
>

Actions: View | Splinter Review

Attachments on bug 57988: 71137 | 71138 | 71140 | 71141 | 71142 | 71144 | 71145 | 71146 | 71147

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.