Attachment 93947 Details for Bug 74882 – Flush the render cache between operations

[patch] Flush the render cache between operations

0001-sna-gen5-Flush-the-render-cache-between-operations.patch (text/plain), 1.31 KB, created by Chris Wilson on 2014-02-12 16:38:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2014-02-12 16:38:23 UTC

Size: 1.31 KB

patch

obsolete

>From fb89bfc73f4103ca6116c8f91970f4bfa491636c Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Wed, 12 Feb 2014 16:41:51 +0000
>Subject: [PATCH 1/2] sna/gen5: Flush the render cache between operations
>
>When we change the blend mode between operations, it appears that we
>must flush the render cache or else we risk render corruption. This is
>usually noticeable in rendering of single glyphs.
>
>This was originally fixed for bug 51422, but was reintroduced by
>commit 37eb7343be1aeeb90a860096756603a577df1a77
>Author: Chris Wilson <chris@chris-wilson.co.uk>
>Date:   Sat Dec 1 09:40:11 2012 +0000
>
>    sna/gen5: Inspired by gen4, reorder the flushing
>and the desire to reduce the impact of this w/a.
>
>Reported-by: itumaykin@gmail.com
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74882
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> src/sna/gen5_render.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/sna/gen5_render.c b/src/sna/gen5_render.c
>index c5ccaac..d5856ea 100644
>--- a/src/sna/gen5_render.c
>+++ b/src/sna/gen5_render.c
>@@ -1017,7 +1017,7 @@ gen5_emit_vertex_elements(struct sna *sna,
> inline static void
> gen5_emit_pipe_flush(struct sna *sna)
> {
>-#if 0
>+#if 1
> 	OUT_BATCH(GEN5_PIPE_CONTROL |
> 		  GEN5_PIPE_CONTROL_WC_FLUSH |
> 		  (4 - 2));
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 74882: 93922 | 93929 | 93947 | 93948

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.