Attachment 105915 Details for Bug 83396 – password update errors

[patch] password update errors

0010-oauth2-handle-errors-during-password-update.patch (text/plain), 1.96 KB, created by Patrick Ohly on 2014-09-08 18:50:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick Ohly

Created: 2014-09-08 18:50:02 UTC

Size: 1.96 KB

patch

obsolete

>From 23ac04d63200a309945ba7e68d28672ce76656ee Mon Sep 17 00:00:00 2001
>From: Patrick Ohly <patrick.ohly@intel.com>
>Date: Mon, 8 Sep 2014 20:36:44 +0200
>Subject: [PATCH 10/10] oauth2: handle errors during password update
>
>There is no guarantee that the password can be updated. Allow the attempt
>to fail without treating it as an error (that would be confusing in the most
>common case, where "password" was given on the command line) and instead
>just print an INFO message with the new token and some instructions.
>---
> src/backends/oauth2/oauth2.cpp | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/src/backends/oauth2/oauth2.cpp b/src/backends/oauth2/oauth2.cpp
>index 5a8d19d..3f75cc5 100644
>--- a/src/backends/oauth2/oauth2.cpp
>+++ b/src/backends/oauth2/oauth2.cpp
>@@ -107,9 +107,14 @@ public:
>                         }
>                         if (strcmp("refresh_token", key) == 0) {
>                             std::string newRefreshToken = json_object_get_string(val);
>-                            SE_LOG_INFO(NULL, "refresh token invalidated - updating refresh token to %s", newRefreshToken.c_str());
>                             if (passwordUpdateCallback) {
>-                                passwordUpdateCallback(newRefreshToken);
>+                                try {
>+                                    passwordUpdateCallback(newRefreshToken);
>+                                } catch (...) {
>+                                    std::string explanation;
>+                                    Exception::handle(explanation, HANDLE_EXCEPTION_NO_ERROR);
>+                                    SE_LOG_INFO(NULL, "The attempt to update the refresh token in the 'password' property failed, probably because there is no configuration for it: %s\nRemember to use the new token in the future: %s", explanation.c_str(), newRefreshToken.c_str());
>+                                }
>                             }
>                         }
>                     }
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 83396: 105605 | 105737 | 105906 | 105907 | 105908 | 105909 | 105910 | 105911 | 105912 | 105913 | 105914 | 105915 | 105955 | 105956 | 105981

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.