From d7ed302bcf0250412c3c4774474b05bf56051d59 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Wed, 23 Mar 2016 09:29:48 +0000 Subject: [PATCH] polkitbackend: Fix error reporting when loading a config file The GError* was not being passed to g_key_file_load_from_file(), but was being used in the error handling for when it failed, which would have caused a NULL pointer dereference. Spotted by Coverity (CID: #77843). https://bugs.freedesktop.org/show_bug.cgi?id=94670 --- src/polkitbackend/polkitbackendconfigsource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/polkitbackend/polkitbackendconfigsource.c b/src/polkitbackend/polkitbackendconfigsource.c index 838bc6a..8a12f20 100644 --- a/src/polkitbackend/polkitbackendconfigsource.c +++ b/src/polkitbackend/polkitbackendconfigsource.c @@ -370,7 +370,7 @@ polkit_backend_config_source_ensure (PolkitBackendConfigSource *source) if (!g_key_file_load_from_file (key_file, filename, G_KEY_FILE_NONE, - NULL)) + &error)) { g_warning ("Error loading key-file %s: %s", filename, error->message); g_error_free (error); -- 2.5.0