From 0afc01c288add5919b176ca0dd73e90a09ae1203 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Fri, 7 Oct 2016 19:16:16 +0100 Subject: [PATCH 04/13] Print errors parsing match rules correctly Not an exploitable vulnerability, just incorrect output. Signed-off-by: Simon McVittie --- bus/signals.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bus/signals.c b/bus/signals.c index f28aaa3..838161f 100644 --- a/bus/signals.c +++ b/bus/signals.c @@ -871,7 +871,7 @@ bus_match_rule_parse_arg_match (BusMatchRule *rule, else { dbus_set_error (error, DBUS_ERROR_MATCH_RULE_INVALID, - "Key '%s' in match rule contains junk after argument number (%u). Only 'arg%upath' (for example) or 'arg0namespace' are valid", key, arg, arg); + "Key '%s' in match rule contains junk after argument number (%lu). Only 'arg%lupath' (for example) or 'arg0namespace' are valid", key, arg, arg); goto failed; } } @@ -889,7 +889,7 @@ bus_match_rule_parse_arg_match (BusMatchRule *rule, rule->args[arg] != NULL) { dbus_set_error (error, DBUS_ERROR_MATCH_RULE_INVALID, - "Argument %d matched more than once in match rule\n", key); + "Argument %s matched more than once in match rule\n", key); goto failed; } -- 2.9.3