From fcb43fb7c9b37c8717e651077ca903d9ee67f711 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Fri, 7 Oct 2016 19:13:33 +0100 Subject: [PATCH 11/13] Add missing format attributes suggested by -Wsuggest-attribute=format Signed-off-by: Simon McVittie --- bus/selinux.c | 2 +- dbus/dbus-errors.h | 2 +- dbus/dbus-string.h | 2 +- dbus/dbus-sysdeps.h | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/bus/selinux.c b/bus/selinux.c index a904f0a..16791c8 100644 --- a/bus/selinux.c +++ b/bus/selinux.c @@ -71,7 +71,7 @@ static security_id_t bus_sid = SECSID_WILD; static pthread_t avc_notify_thread; /* Prototypes for AVC callback functions. */ -static void log_callback (const char *fmt, ...); +static void log_callback (const char *fmt, ...) _DBUS_GNUC_PRINTF (1, 2); static void log_audit_callback (void *data, security_class_t class, char *buf, size_t bufleft); static void *avc_create_thread (void (*run) (void)); static void avc_stop_thread (void *thread); diff --git a/dbus/dbus-errors.h b/dbus/dbus-errors.h index e63139a..3804085 100644 --- a/dbus/dbus-errors.h +++ b/dbus/dbus-errors.h @@ -69,7 +69,7 @@ DBUS_EXPORT void dbus_set_error (DBusError *error, const char *name, const char *message, - ...); + ...) _DBUS_GNUC_PRINTF (3, 4); DBUS_EXPORT void dbus_set_error_const (DBusError *error, const char *name, diff --git a/dbus/dbus-string.h b/dbus/dbus-string.h index ae2a238..1c01770 100644 --- a/dbus/dbus-string.h +++ b/dbus/dbus-string.h @@ -203,7 +203,7 @@ dbus_bool_t _dbus_string_append_printf (DBusString *str, DBUS_PRIVATE_EXPORT dbus_bool_t _dbus_string_append_printf_valist (DBusString *str, const char *format, - va_list args); + va_list args) _DBUS_GNUC_PRINTF (2, 0); dbus_bool_t _dbus_string_insert_2_aligned (DBusString *str, int insert_at, const unsigned char octets[2]); diff --git a/dbus/dbus-sysdeps.h b/dbus/dbus-sysdeps.h index 3387347..2ef4bf2 100644 --- a/dbus/dbus-sysdeps.h +++ b/dbus/dbus-sysdeps.h @@ -483,7 +483,7 @@ void _dbus_exit (int code) _DBUS_GNUC_NORETURN; DBUS_PRIVATE_EXPORT int _dbus_printf_string_upper_bound (const char *format, - va_list args); + va_list args) _DBUS_GNUC_PRINTF (1, 0); #ifdef DBUS_ENABLE_VERBOSE_MODE DBUS_PRIVATE_EXPORT @@ -568,7 +568,7 @@ void _dbus_log (DBusSystemLogSeverity severity, DBUS_PRIVATE_EXPORT void _dbus_logv (DBusSystemLogSeverity severity, const char *msg, - va_list args); + va_list args) _DBUS_GNUC_PRINTF (2, 0); /* Define DBUS_VA_COPY() to do the right thing for copying va_list variables. * config.h may have already defined DBUS_VA_COPY as va_copy or __va_copy. -- 2.9.3