From e0dc10a41dc638b391047779b2e5795bfc666062 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Fri, 9 Dec 2016 16:27:25 +0000 Subject: [PATCH] Related: rhbz#1314595 Annot::getRotation(): evince killed by SIGABRT from the bt we can see that pageobj was null in practice here. I'm betting that flags & flagNoRotate is unset, so suggest that the assert go with the use of pageobj --- poppler/Annot.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/poppler/Annot.cc b/poppler/Annot.cc index 51a80e5..bd446a9 100644 --- a/poppler/Annot.cc +++ b/poppler/Annot.cc @@ -1894,10 +1894,9 @@ GBool Annot::isVisible(GBool printing) { int Annot::getRotation() const { - Page *pageobj = doc->getPage(page); - assert(pageobj != NULL); - if (flags & flagNoRotate) { + Page *pageobj = doc->getPage(page); + assert(pageobj != NULL); return (360 - pageobj->getRotate()) % 360; } else { return 0; -- 2.9.3