From a7b4848e4329c70888be7f30a533990396b208dd Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Thu, 8 Jun 2017 18:17:31 +0100 Subject: [PATCH] bus/driver: Containers can't use the Verbose and Stats interfaces These are debugging interfaces, which are essentially read-only. By default, Verbose is not available on the system bus at all and Stats is only available to uid 0, but both are available on the session bus, and they can be allowed for other uids by configuring the system bus. Signed-off-by: Simon McVittie https://bugs.freedesktop.org/show_bug.cgi?id=101354 --- bus/driver.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/bus/driver.c b/bus/driver.c index fec485c8..ee90cf3e 100644 --- a/bus/driver.c +++ b/bus/driver.c @@ -2578,9 +2578,9 @@ static const MessageHandler monitoring_message_handlers[] = { #ifdef DBUS_ENABLE_VERBOSE_MODE static const MessageHandler verbose_message_handlers[] = { { "EnableVerbose", "", "", bus_driver_handle_enable_verbose, - METHOD_FLAG_NONE }, + METHOD_FLAG_NO_CONTAINERS }, { "DisableVerbose", "", "", bus_driver_handle_disable_verbose, - METHOD_FLAG_NONE }, + METHOD_FLAG_NO_CONTAINERS }, { NULL, NULL, NULL, NULL } }; #endif @@ -2588,11 +2588,11 @@ static const MessageHandler verbose_message_handlers[] = { #ifdef DBUS_ENABLE_STATS static const MessageHandler stats_message_handlers[] = { { "GetStats", "", "a{sv}", bus_stats_handle_get_stats, - METHOD_FLAG_NONE }, + METHOD_FLAG_NO_CONTAINERS }, { "GetConnectionStats", "s", "a{sv}", bus_stats_handle_get_connection_stats, - METHOD_FLAG_NONE }, + METHOD_FLAG_NO_CONTAINERS }, { "GetAllMatchRules", "", "a{sas}", bus_stats_handle_get_all_match_rules, - METHOD_FLAG_NONE }, + METHOD_FLAG_NO_CONTAINERS }, { NULL, NULL, NULL, NULL } }; #endif -- 2.13.3