From f1b950dc2ee9356c98e336aa002320ca0154b352 Mon Sep 17 00:00:00 2001 From: Oliver Sander Date: Tue, 22 Aug 2017 11:43:08 +0200 Subject: [PATCH 3/3] Use Qt::SvgMiterJoin instead of Qt::MiterJoin The two differ in what happens when the miter limit is exceeded. According to https://bugreports.qt.io/browse/QTBUG-52640 Qt::SvgMiterJoin is what the pdf standard requires. Closes: https://bugs.freedesktop.org/show_bug.cgi?id=102356 --- qt5/src/ArthurOutputDev.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qt5/src/ArthurOutputDev.cc b/qt5/src/ArthurOutputDev.cc index 7d103d11..25afc7af 100644 --- a/qt5/src/ArthurOutputDev.cc +++ b/qt5/src/ArthurOutputDev.cc @@ -208,7 +208,10 @@ void ArthurOutputDev::updateLineJoin(GfxState *state) { switch (state->getLineJoin()) { case 0: - m_currentPen.setJoinStyle(Qt::MiterJoin); + // The correct style here is Qt::SvgMiterJoin, *not* Qt::MiterJoin. + // The two differ in what to do if the miter limit is exceeded. + // See https://bugs.freedesktop.org/show_bug.cgi?id=102356 + m_currentPen.setJoinStyle(Qt::SvgMiterJoin); break; case 1: m_currentPen.setJoinStyle(Qt::RoundJoin); -- 2.14.1