From b4168c568ac330c7337a5d09a47bdd5df053a83c Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Tue, 19 Dec 2017 20:00:46 +0000 Subject: [PATCH 2/2] GetConnectionCredentials: Don't include Containers1 Type, Name It isn't clear whether we want these in GetConnectionCredentials(), because if we later open up different-uid access to the container sockets, it raises questions of how strongly we can trust that information. Signed-off-by: Simon McVittie --- bus/driver.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/bus/driver.c b/bus/driver.c index eff448d2..58ee19f2 100644 --- a/bus/driver.c +++ b/bus/driver.c @@ -2011,11 +2011,7 @@ bus_driver_handle_get_connection_credentials (DBusConnection *connection, { if (!_dbus_asv_add_object_path (&array_iter, DBUS_INTERFACE_CONTAINERS1 ".Instance", - path) || - !_dbus_asv_add_string (&array_iter, - DBUS_INTERFACE_CONTAINERS1 ".Type", type) || - !_dbus_asv_add_string (&array_iter, - DBUS_INTERFACE_CONTAINERS1 ".Name", name)) + path)) goto oom; } -- 2.15.1